Skip to content

Commit 73e008b

Browse files
JohnAZoidbergquinchou77
authored andcommitted
Revert "fwk: Fix ignoring powerbutton if lid closed from G3"
It's buggy: ``` /mnt/host/source/src/platform/ec/zephyr/program/framework/src/power_button_x86.c: In function 'set_initial_pwrbtn_state': /mnt/host/source/src/platform/ec/zephyr/program/framework/src/power_button_x86.c:257:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation] 257 | if (!lid_is_open()) | ^~ /mnt/host/source/src/platform/ec/zephyr/program/framework/src/power_button_x86.c:259:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 259 | return; | ^~~~~~ ``` This reverts commit 637d4d5bc00756eb02c206dd529168d3758e5648. Signed-off-by: Daniel Schaefer <[email protected]> (cherry picked from commit 7853b66ec92817d74a3c83cb28b732a7832805ad)
1 parent 14d61d9 commit 73e008b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

zephyr/program/framework/src/power_button_x86.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ static void power_button_debounce_deferred(void)
210210
* Power button already release ignore PB signal
211211
*/
212212
pwrbtn_state = PWRBTN_STATE_IDLE;
213-
CPRINTS("PB debounce ignore signal - debounce");
213+
CPRINTS("PB debounce ignore signal");
214214
} else {
215215
/**
216216
* Power button is still pressed, power on the system
@@ -241,7 +241,7 @@ static void set_initial_pwrbtn_state(void)
241241
(gpio_pin_get_dt(GPIO_DT_FROM_NODELABEL(gpio_on_off_btn_l)) == 1) &&
242242
!get_standalone_mode()) {
243243
pwrbtn_state = PWRBTN_STATE_IDLE;
244-
CPRINTS("PB ignore signal - chassis open");
244+
CPRINTS("PB ignore signal");
245245
return;
246246
}
247247

0 commit comments

Comments
 (0)