Skip to content

Commit 7928b05

Browse files
emerson-bemersonlabs
andauthored
github413: Update listeners for Allure reporting (#414)
re-introduce static reference Co-authored-by: emersonlabs <[email protected]>
1 parent 789e16c commit 7928b05

File tree

6 files changed

+15
-24
lines changed

6 files changed

+15
-24
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<groupId>com.github.frameworkium</groupId>
55
<artifactId>frameworkium-core</artifactId>
6-
<version>4.2.1-1-SNAPSHOT</version>
6+
<version>4.2.1-18-SNAPSHOT</version>
77
<name>frameworkium-core</name>
88
<description>
99
Frameworkium core code.
@@ -83,7 +83,7 @@
8383
<dependency>
8484
<groupId>org.testng</groupId>
8585
<artifactId>testng</artifactId>
86-
<version>7.6.0</version>
86+
<version>7.6.1</version>
8787
</dependency>
8888

8989
<dependency>

src/main/java/com/frameworkium/core/api/tests/BaseAPITest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
package com.frameworkium.core.api.tests;
22

3-
import com.frameworkium.core.common.listeners.MethodInterceptor;
4-
import com.frameworkium.core.common.listeners.ResultLoggerListener;
5-
import com.frameworkium.core.common.listeners.TestListener;
63
import com.frameworkium.core.common.reporting.allure.AllureProperties;
74
import org.apache.logging.log4j.LogManager;
85
import org.apache.logging.log4j.Logger;
96
import org.testng.annotations.AfterSuite;
10-
import org.testng.annotations.Listeners;
117
import org.testng.annotations.Test;
128

13-
@Listeners({MethodInterceptor.class,
14-
TestListener.class,
15-
ResultLoggerListener.class})
9+
// Uses the listeners in main.resources.META-INF.services.org.testng.ITestNGListener
1610
@Test(groups = "base-api")
1711
public abstract class BaseAPITest {
1812

src/main/java/com/frameworkium/core/htmlelements/element/FileInput.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public void setFileToUpload(final String fileName) {
4343
setLocalFileDetectorIfRequired();
4444

4545
String filePath = getFilePath(fileName);
46-
sendKeys(filePath);
46+
sendKeys(new File(filePath).toString());
4747
}
4848

4949
/**

src/main/java/com/frameworkium/core/ui/listeners/ScreenshotListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
import org.openqa.selenium.OutputType;
1919
import org.openqa.selenium.TakesScreenshot;
2020
import org.openqa.selenium.WebDriverException;
21+
import org.testng.ITestListener;
2122
import org.testng.ITestResult;
22-
import org.testng.TestListenerAdapter;
2323

24-
public class ScreenshotListener extends TestListenerAdapter {
24+
public class ScreenshotListener implements ITestListener {
2525

2626
private static final Logger logger = LogManager.getLogger();
2727
private final boolean captureEnabled = ScreenshotCapture.isRequired();

src/main/java/com/frameworkium/core/ui/tests/BaseUITest.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
package com.frameworkium.core.ui.tests;
22

3-
import com.frameworkium.core.common.listeners.MethodInterceptor;
4-
import com.frameworkium.core.common.listeners.ResultLoggerListener;
5-
import com.frameworkium.core.common.listeners.TestListener;
63
import com.frameworkium.core.ui.UITestLifecycle;
74
import com.frameworkium.core.ui.capture.ScreenshotCapture;
85
import com.frameworkium.core.ui.driver.Driver;
9-
import com.frameworkium.core.ui.listeners.CaptureListener;
10-
import com.frameworkium.core.ui.listeners.SauceLabsListener;
11-
import com.frameworkium.core.ui.listeners.ScreenshotListener;
12-
import com.frameworkium.core.ui.listeners.VideoListener;
136
import com.saucelabs.common.SauceOnDemandAuthentication;
147
import com.saucelabs.common.SauceOnDemandSessionIdProvider;
158
import com.saucelabs.testng.SauceOnDemandAuthenticationProvider;
@@ -26,13 +19,9 @@
2619
import org.testng.annotations.AfterSuite;
2720
import org.testng.annotations.BeforeMethod;
2821
import org.testng.annotations.BeforeSuite;
29-
import org.testng.annotations.Listeners;
3022
import org.testng.annotations.Test;
3123

32-
@Listeners({
33-
CaptureListener.class, ScreenshotListener.class, MethodInterceptor.class,
34-
SauceLabsListener.class, TestListener.class, ResultLoggerListener.class,
35-
VideoListener.class})
24+
// Uses the listeners in main.resources.META-INF.services.org.testng.ITestNGListener
3625
@Test(groups = "base-ui")
3726
public abstract class BaseUITest
3827
implements SauceOnDemandSessionIdProvider, SauceOnDemandAuthenticationProvider {
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
io.qameta.allure.testng.AllureTestNg
2+
com.frameworkium.core.common.listeners.TestListener
3+
com.frameworkium.core.common.listeners.ResultLoggerListener
4+
com.frameworkium.core.ui.listeners.ScreenshotListener
5+
com.frameworkium.core.ui.listeners.CaptureListener
6+
com.frameworkium.core.ui.listeners.SauceLabsListener
7+
com.frameworkium.core.ui.listeners.VideoListener
8+
com.frameworkium.core.common.listeners.MethodInterceptor

0 commit comments

Comments
 (0)