Improve instruction constructor parameter names #977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more accurate names for instruction constructor parameters in
fuel-asm. In particular:TROreferred to contract id, when it's in fact an address_ptr(or simply calledptr). Previously there was a mix of different conventions, including_addr,_ptrsuffixes or no suffix at all.This is a non-breaking change as only names of function parameters are changed.
Checklist
Before requesting review
Note
Standardizes instruction constructor parameter names in
fuel-asm, replacing *_addr with *_ptr (and related renames) and correcting several misnamed parameters likeTRO’s recipient address.addr->ptracross memory, I/O, crypto, storage, and hashing ops (e.g.,RETD ptr,MCL dst_ptr,MCP dst_ptr/src_ptr,MEQ lhs_ptr/rhs_ptr,LOGD ptr,LB/LW/SB/SW ptr,MCPI dst_ptr/src_ptr,MCLI ptr,BAL asset_id_ptr/contract_id_ptr).TR contract_id_ptr,TRO recipient_address_ptr(was contract id),CALL asset_id_ptr,CCP/CROO/CSIZ contract_id_ptr,LDC src_ptr,SMO recipient_address_ptr/data_ptr.*_ptrfor buffers:ECK1/ECR1/K256/S256 dst_ptr/src_ptr,ED19 pub_key_ptr/sig_ptr/msg_ptr.key_ptr,dst_ptr,src_ptr:SCWQ/SRW/SRWQ/SWW/SWWQ.JAL ret_ptr.WDCM/WQCM/WDOP/WQOP/WDML/WQML/WDDV/WQDV/WDMD/WQMD/WDAM/WQAM/WDMM/WQMMusedst_ptr/lhs_ptr/rhs_ptrand*_ptrfor multi-operand args.ECOP dst_ptr.Written by Cursor Bugbot for commit f9665cd. This will update automatically on new commits. Configure here.