Revert "Refactor Strumline getXPos to support multi-directional notes"

This reverts commit 0d8bb28.

Author: Starexify

source/funkin/play/notes/Strumline.hx

@@ -1302,12 +1302,17 @@ class Strumline extends FlxSpriteGroup
     #if mobile
     if (inArrowContorlSchemeMode && isPlayer) pos = 35 * (FlxG.width / FlxG.height) / (FlxG.initialWidth / FlxG.initialHeight);
     #end
-
-    var spacing:Float = Strumline.NOTE_SPACING * noteSpacingScale * strumlineScale.x;
-    var halfLength:Int = Math.floor(Strumline.DIRECTIONS.length / 2);
-    var baseOffset:Float = ((direction : Int) < halfLength) ? -pos * 2 : pos;
-
-    return baseOffset + (direction * spacing);
+    return switch (direction)
+    {
+      case NoteDirection.LEFT: -pos * 2;
+      case NoteDirection.DOWN:
+        -(pos * 2) + (1 * Strumline.NOTE_SPACING) * (noteSpacingScale * strumlineScale.x);
+      case NoteDirection.UP:
+        pos + (2 * Strumline.NOTE_SPACING) * (noteSpacingScale * strumlineScale.x);
+      case NoteDirection.RIGHT:
+        pos + (3 * Strumline.NOTE_SPACING) * (noteSpacingScale * strumlineScale.x);
+      default: -pos * 2;
+    }
   }
 
   /**

source/funkin/play/notes/notestyle/NoteStyle.hx

@@ -999,7 +999,7 @@ class NoteStyle implements IRegistryEntry<NoteStyleData>
 
     target.antialiasing = !(_data.assets.holdNoteCover?.isPixel ?? false);
     target.glow.antialiasing = !(_data.assets.holdNoteCover?.isPixel ?? false);
-    target.scale.set(getHoldCoverScale(), getHoldCoverScale());
+    target.scale.set(_data.assets.holdNoteCover?.scale ?? 1.0, _data.assets.holdNoteCover?.scale ?? 1.0);
     target.updateHitbox();
     target.glow.updateHitbox();
 
@@ -1157,11 +1157,6 @@ class NoteStyle implements IRegistryEntry<NoteStyleData>
     return _data?.assets?.holdNoteCover?.offsets ?? fallback?.getHoldCoverOffsets() ?? [0.0, 0.0];
   }
 
-  public function getHoldCoverScale():Float
-  {
-    return _data?.assets?.holdNoteCover?.scale ?? fallback?.getHoldCoverScale() ?? 1.0;
-  }
-
   public function destroy():Void {}
 
   /**