refactor: Centralize error output #3902
Open
+702
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
… in try/catch statements Problem: Retrieves everything that was thrown, so not just the message.
…/catch in main)": remove useless try/catch
…y spaces. The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test "value".
MelReyCG
requested changes
Nov 26, 2025
Comment on lines
244
to
245
| ErrorLogger::formatMsgToAscii( GEOS_GLOBAL_LOGGER.currentErrorMsg(), \ | ||
| __asciiErrormSG ); \ |
Contributor
There was a problem hiding this comment.
Is it really useful to output the message here to the log?
The ErrorMsg get more and more info along the catch potencial cascade, then at the main() catch, it get fully flushed to the YAML. Why not doing the same for the log?
| msgStruct.setCause( __causemsgsoss.str() ); \ | ||
| msgStruct.addCallStackInfo( LvArray::system::stackTrace( true ) ); \ | ||
| msgStruct.addContextInfo( GEOS_DETAIL_REST_ARGS( __VA_ARGS__ ) ); \ | ||
| ErrorLogger::formatMsgToAscii( msgStruct, GEOS_GLOBAL_LOGGER.getErrorStream() ); \ |
Contributor
There was a problem hiding this comment.
I feel like formatMsgToAscii() should be done internally by flushErrorMsg().
Is it passing the unit test on your side?
Do you have a error/throw/warning test series? (I think you should have like at least 5 tests to validate, but unit tests should do that)
| }; | ||
|
|
||
| /** | ||
| * @brief Retrieve all informations from the ErrorLogger and format into a stream |
Contributor
There was a problem hiding this comment.
Suggested change
| * @brief Retrieve all informations from the ErrorLogger and format into a stream | |
| * @brief Retrieve all informations from the ErrorMsg and format into a stream. |
And IF it is needed to be public, you can add:
* Useful for formating a message log text externally.
| else | ||
| { | ||
| GEOS_LOG_RANK( GEOS_FMT( "Unable to open error file for writing.\n- Error file: {}\n- Error file enabled = {}.\n", | ||
| m_filename, g_errorLogger.isOutputFileEnabled() ) ); |
Comment on lines
213
to
218
| __FILE__, line1 ), | ||
| "- frame0: ", | ||
| "- frame1: ", | ||
| "- frame2: " | ||
| } ); | ||
| } |
src/main/main.cpp
Outdated
Comment on lines
78
to
80
| ErrorLogger::global().getErrorStream() << e.what(); | ||
| ErrorLogger::global().flushErrorMsg( ErrorLogger::global().currentErrorMsg() ); | ||
| LvArray::system::callErrorHandler(); |
Contributor
There was a problem hiding this comment.
I'm not sure this is the right direction (this is related with my other comments).
arng40
requested review from
Guotong-Ren,
acitrain,
frankfeifan,
rasimHZ,
sframba,
tjb-ltk and
victorapm
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code duplication found in
GEOS_THROW,GEOS_ERROR,GEOS_WARNINGand put into a static function inErrorLogger.Called while
flushErrorMsg()