Fixes after review 2

Author: alexbenedicto

geos-mesh/src/geos/mesh/doctor/actions/generateFractures.py

@@ -479,14 +479,7 @@ def __generateFractureMesh( oldMesh: vtkUnstructuredGrid, fractureInfo: Fracture
                 discardedFaceNodes.add( ns )
 
     if discardedFaceNodes:
-        # tmp = list()
-        # for dfns in discardedFaceNodes:
-        #     tmp.append(", ".join(map(str, dfns)))
         msg: str = "(" + '), ('.join( map( lambda dfns: ", ".join( map( str, dfns ) ), discardedFaceNodes ) ) + ")"
-        # setupLogger.info(f"The {len(tmp)} faces made of nodes ({'), ('.join(tmp)}) were/was discarded"
-        #                   + "from the fracture mesh because none of their/its nodes were duplicated.")
-        # print(f"The {len(tmp)} faces made of nodes ({'), ('.join(tmp)}) were/was discarded"
-        #              + "from the fracture mesh because none of their/its nodes were duplicated.")
         setupLogger.info( f"The faces made of nodes [{msg}] were/was discarded"
                           " from the fracture mesh because none of their/its nodes were duplicated." )
 

geos-mesh/src/geos/mesh/doctor/actions/nonConformal.py

@@ -247,14 +247,14 @@ def __init__( self, boundaryMesh: BoundaryMesh, faceTolerance: float ):
         self.__faceTolerance = faceTolerance
 
     def __extrude( self, polygonPolyData: vtkPolyData, normal: numpy.ndarray ) -> vtkPolyData:
-        """Extrude the polygon data to create a volume that will be used for intersection.
+        """Extrude the polygon data to create a surface that will be used for intersection.
 
         Args:
             polygonPolyData (vtkPolyData): The data to extrude
             normal (numpy.ndarray): The (uniform) direction of the extrusion.
 
         Returns:
-            vtkPolyData: The extruded volume.
+            vtkPolyData: The extruded surface.
         """
         extruder = vtkLinearExtrusionFilter()
         extruder.SetExtrusionTypeToVectorExtrusion()

geos-mesh/src/geos/mesh/doctor/actions/reorientMesh.py

@@ -14,10 +14,11 @@
 def __computeVolume( meshPoints: vtkPoints, faceStream: FaceStream ) -> float:
     """Computes the volume of a polyhedron element (defined by its faceStream).
 
-    To note that the faces of the polyhedron are triangulated and the volumes of the tetrahedra
-    from the barycenter to the triangular bases are summed.
-    The normal of each face plays critical role,
-    since the volume of each tetrahedron can be positive or negative.
+    .. Note::
+        The faces of the polyhedron are triangulated and the volumes of the tetrahedra
+        from the barycenter to the triangular bases are summed.
+        The normal of each face plays critical role,
+        since the volume of each tetrahedron can be positive or negative.
 
     Args:
         meshPoints (vtkPoints): The mesh points, needed to compute the volume.

geos-mesh/src/geos/mesh/doctor/actions/supportedElements.py

@@ -108,7 +108,7 @@ def __isPolyhedronSupported( self, faceStream ) -> str:
         return ""
 
     def __call__( self, ic: int ) -> int:
-        """Checks if a vtk polyhedron cell can be converted into a supported GEOSX element.
+        """Checks if a vtk polyhedron cell can be converted into a supported GEOS element.
 
         Args:
             ic (int): The index element.

geos-mesh/tests/test_generateFractures.py

@@ -298,8 +298,8 @@ def addQuad( mesh: vtkUnstructuredGrid, face: FaceNodesCoords ):
 
 @pytest.mark.skip( "Test to be fixed" )
 def test_copyFieldsWhenSplittingMesh():
-    """This test is designed to check the __copyFields method from generate_fractures,
-    that will be called when using __splitMeshOnFractures method from generate_fractures.
+    """This test is designed to check the __copyFields method from generateFractures,
+    that will be called when using __splitMeshOnFractures method from generateFractures.
     """
     # Generating the rectilinear grid and its quads on all borders
     x: numpy.array = numpy.array( [ 0, 1, 2 ] )