Add isEmpty method to various types (String, Uuid, DateTime, Bool) with tests for consistent behavior across value objects.

georgedeploy · georgedeploy · commit 022c7fd5465f · 2025-12-14T23:46:42.000+01:00
diff --git a/src/Bool/TrueStandard.php b/src/Bool/TrueStandard.php
@@ -125,4 +125,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/Timestamp/TimestampMilliseconds.php b/src/DateTime/Timestamp/TimestampMilliseconds.php
@@ -140,4 +140,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/Timestamp/TimestampSeconds.php b/src/DateTime/Timestamp/TimestampSeconds.php
@@ -109,4 +109,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/String/MariaDb/StringText.php b/src/String/MariaDb/StringText.php
@@ -87,4 +87,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return $this->value === '';
+    }
 }
diff --git a/src/String/MariaDb/StringVarChar255.php b/src/String/MariaDb/StringVarChar255.php
@@ -85,4 +85,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return $this->value === '';
+    }
 }
diff --git a/src/String/StringStandard.php b/src/String/StringStandard.php
@@ -73,4 +73,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return $this->value === '';
+    }
 }
diff --git a/src/String/StringUrl.php b/src/String/StringUrl.php
@@ -93,4 +93,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/String/Uuid/StringUuidV4.php b/src/String/Uuid/StringUuidV4.php
@@ -102,4 +102,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/String/Uuid/StringUuidV7.php b/src/String/Uuid/StringUuidV7.php
@@ -102,4 +102,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Undefined/UndefinedStandard.php b/src/Undefined/UndefinedStandard.php
@@ -84,4 +84,9 @@ public function jsonSerialize(): never
     {
         throw new UndefinedTypeException('UndefinedType cannot be serialized for Json.');
     }
+
+    public function isEmpty(): bool
+    {
+        return true;
+    }
 }
diff --git a/tests/Unit/Bool/TrueStandardTest.php b/tests/Unit/Bool/TrueStandardTest.php
@@ -100,3 +100,7 @@ public function __toString(): string
         ->and($fromArray)->toBeInstanceOf(Undefined::class)
         ->and($fromNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for TrueStandard', function (): void {
+    expect(TrueStandard::fromString('yes')->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/Timestamp/TimestampMillisecondsTest.php b/tests/Unit/DateTime/Timestamp/TimestampMillisecondsTest.php
@@ -161,3 +161,8 @@ public function __toString(): string
         ->and($fromArray)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
         ->and($fromNull)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class);
 });
+
+it('isEmpty is always false for TimestampMilliseconds', function (): void {
+    $vo = TimestampMilliseconds::fromString('0');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/Timestamp/TimestampSecondsTest.php b/tests/Unit/DateTime/Timestamp/TimestampSecondsTest.php
@@ -160,3 +160,8 @@ public function __toString(): string
         ->and($fromArray)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
         ->and($fromNull)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class);
 });
+
+it('isEmpty is always false for TimestampSeconds', function (): void {
+    $vo = TimestampSeconds::fromString('0');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/String/MariaDb/StringTextTest.php b/tests/Unit/String/MariaDb/StringTextTest.php
@@ -96,3 +96,11 @@ public function __toString(): string
         ->and($fromNull)->toBeInstanceOf(StringText::class)
         ->and($fromNull->value())->toBe('');
 });
+
+it('isEmpty is true for empty and false for non-empty StringText', function (): void {
+    $empty = new StringText('');
+    $nonEmpty = StringText::fromString('x');
+
+    expect($empty->isEmpty())->toBeTrue()
+        ->and($nonEmpty->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/String/MariaDb/StringVarChar255Test.php b/tests/Unit/String/MariaDb/StringVarChar255Test.php
@@ -102,3 +102,11 @@ public function __toString(): string
         ->and($fromNull)->toBeInstanceOf(StringVarChar255::class)
         ->and($fromNull->value())->toBe('');
 });
+
+it('isEmpty is true for empty and false for non-empty StringVarChar255', function (): void {
+    $empty = new StringVarChar255('');
+    $nonEmpty = StringVarChar255::fromString('x');
+
+    expect($empty->isEmpty())->toBeTrue()
+        ->and($nonEmpty->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/String/StringStandardTest.php b/tests/Unit/String/StringStandardTest.php
@@ -63,3 +63,13 @@
     expect((string) $s)->toBe('cast test')
         ->and($s->__toString())->toBe('cast test');
 });
+
+it('isEmpty is false for non-empty StringStandard', function (): void {
+    $s = StringStandard::fromString('x');
+    expect($s->isEmpty())->toBeFalse();
+});
+
+it('isEmpty is true for empty StringStandard', function (): void {
+    $s = StringStandard::fromString('');
+    expect($s->isEmpty())->toBeTrue();
+});
diff --git a/tests/Unit/String/StringUrlTest.php b/tests/Unit/String/StringUrlTest.php
@@ -80,3 +80,8 @@ public function __toString(): string
         ->and($url->value())
         ->toBe('https://example.com/path');
 });
+
+it('isEmpty is always false for StringUrl', function (): void {
+    $u = new StringUrl('https://example.com');
+    expect($u->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/String/Uuid/StringUuidV4Test.php b/tests/Unit/String/Uuid/StringUuidV4Test.php
@@ -110,3 +110,8 @@ public function __toString(): string
         ->and($fromInt)
         ->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for StringUuidV4', function (): void {
+    $u = new StringUuidV4('550e8400-e29b-41d4-a716-446655440000');
+    expect($u->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/String/Uuid/StringUuidV7Test.php b/tests/Unit/String/Uuid/StringUuidV7Test.php
@@ -110,3 +110,8 @@ public function __toString(): string
         ->and($fromInt)
         ->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for StringUuidV7', function (): void {
+    $u = new StringUuidV7('01890f2a-5bcd-7def-8abc-1234567890ab');
+    expect($u->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Undefined/UndefinedStandardTest.php b/tests/Unit/Undefined/UndefinedStandardTest.php
@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use PhpTypedValues\Exception\UndefinedTypeException;
+use PhpTypedValues\Undefined\Alias\Undefined;
 use PhpTypedValues\Undefined\UndefinedStandard;
 
 it('creates UndefinedStandard via factory', function (): void {
@@ -59,11 +60,19 @@
     $fromNull = UndefinedStandard::tryFromMixed(null);
 
     expect($fromString)
-        ->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
+        ->toBeInstanceOf(Undefined::class)
         ->and($fromInt)
-        ->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
+        ->toBeInstanceOf(Undefined::class)
         ->and($fromArray)
-        ->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
+        ->toBeInstanceOf(Undefined::class)
         ->and($fromNull)
-        ->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class);
+        ->toBeInstanceOf(Undefined::class);
+});
+
+it('isEmpty returns true for UndefinedStandard', function (): void {
+    $u1 = UndefinedStandard::create();
+    $u2 = UndefinedStandard::fromString('ignored');
+
+    expect($u1->isEmpty())->toBeTrue()
+        ->and($u2->isEmpty())->toBeTrue();
 });

Original file line number	Diff line number	Diff line change
`@@ -125,4 +125,9 @@ public function __toString(): string`
`125`	`125`	`{`
`126`	`126`	`return $this->toString();`
`127`	`127`	`}`
	`128`	`+`
	`129`	`+ public function isEmpty(): bool`
	`130`	`+ {`
	`131`	`+ return false;`
	`132`	`+ }`
`128`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,4 +140,9 @@ public static function getFormat(): string`
`140`	`140`	`{`
`141`	`141`	`return static::FORMAT;`
`142`	`142`	`}`
	`143`	`+`
	`144`	`+ public function isEmpty(): bool`
	`145`	`+ {`
	`146`	`+ return false;`
	`147`	`+ }`
`143`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,4 +109,9 @@ public static function getFormat(): string`
`109`	`109`	`{`
`110`	`110`	`return static::FORMAT;`
`111`	`111`	`}`
	`112`	`+`
	`113`	`+ public function isEmpty(): bool`
	`114`	`+ {`
	`115`	`+ return false;`
	`116`	`+ }`
`112`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -87,4 +87,9 @@ public function __toString(): string`
`87`	`87`	`{`
`88`	`88`	`return $this->toString();`
`89`	`89`	`}`
	`90`	`+`
	`91`	`+ public function isEmpty(): bool`
	`92`	`+ {`
	`93`	`+ return $this->value === '';`
	`94`	`+ }`
`90`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,4 +85,9 @@ public function __toString(): string`
`85`	`85`	`{`
`86`	`86`	`return $this->toString();`
`87`	`87`	`}`
	`88`	`+`
	`89`	`+ public function isEmpty(): bool`
	`90`	`+ {`
	`91`	`+ return $this->value === '';`
	`92`	`+ }`
`88`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,4 +73,9 @@ public function __toString(): string`
`73`	`73`	`{`
`74`	`74`	`return $this->toString();`
`75`	`75`	`}`
	`76`	`+`
	`77`	`+ public function isEmpty(): bool`
	`78`	`+ {`
	`79`	`+ return $this->value === '';`
	`80`	`+ }`
`76`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -93,4 +93,9 @@ public function __toString(): string`
`93`	`93`	`{`
`94`	`94`	`return $this->toString();`
`95`	`95`	`}`
	`96`	`+`
	`97`	`+ public function isEmpty(): bool`
	`98`	`+ {`
	`99`	`+ return false;`
	`100`	`+ }`
`96`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,4 +102,9 @@ public function __toString(): string`
`102`	`102`	`{`
`103`	`103`	`return $this->toString();`
`104`	`104`	`}`
	`105`	`+`
	`106`	`+ public function isEmpty(): bool`
	`107`	`+ {`
	`108`	`+ return false;`
	`109`	`+ }`
`105`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,4 +84,9 @@ public function jsonSerialize(): never`
`84`	`84`	`{`
`85`	`85`	`throw new UndefinedTypeException('UndefinedType cannot be serialized for Json.');`
`86`	`86`	`}`
	`87`	`+`
	`88`	`+ public function isEmpty(): bool`
	`89`	`+ {`
	`90`	`+ return true;`
	`91`	`+ }`
`87`	`92`	`}`