Add isEmpty method implementation to multiple types (e.g., DateTime, Float, Integer, Bool) and corresponding tests to ensure consistent behavior across value objects.

georgedeploy · georgedeploy · commit 15451fad31e5 · 2025-12-14T23:45:59.000+01:00
diff --git a/src/Array/ArrayOfObjects.php b/src/Array/ArrayOfObjects.php
@@ -101,9 +101,6 @@ public function count(): int
         return count($this->value);
     }
 
-    /**
-     * Return true if the array is empty, false otherwise.
-     */
     public function isEmpty(): bool
     {
         return $this->count() === 0;
diff --git a/src/Bool/BoolStandard.php b/src/Bool/BoolStandard.php
@@ -121,4 +121,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Bool/FalseStandard.php b/src/Bool/FalseStandard.php
@@ -125,4 +125,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/DateTimeAtom.php b/src/DateTime/DateTimeAtom.php
@@ -105,4 +105,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/DateTimeRFC3339.php b/src/DateTime/DateTimeRFC3339.php
@@ -105,4 +105,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/DateTimeRFC3339Extended.php b/src/DateTime/DateTimeRFC3339Extended.php
@@ -106,4 +106,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/DateTime/DateTimeW3C.php b/src/DateTime/DateTimeW3C.php
@@ -105,4 +105,9 @@ public static function getFormat(): string
     {
         return static::FORMAT;
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Float/FloatNonNegative.php b/src/Float/FloatNonNegative.php
@@ -107,4 +107,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Float/FloatPositive.php b/src/Float/FloatPositive.php
@@ -107,4 +107,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Float/FloatStandard.php b/src/Float/FloatStandard.php
@@ -91,4 +91,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Integer/IntegerNonNegative.php b/src/Integer/IntegerNonNegative.php
@@ -111,4 +111,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/Integer/IntegerPositive.php b/src/Integer/IntegerPositive.php
@@ -111,4 +111,9 @@ public function __toString(): string
     {
         return $this->toString();
     }
+
+    public function isEmpty(): bool
+    {
+        return false;
+    }
 }
diff --git a/tests/Unit/Bool/BoolStandardTest.php b/tests/Unit/Bool/BoolStandardTest.php
@@ -136,3 +136,8 @@ public function __toString(): string
         ->and($fromArray)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class)
         ->and($fromNull)->toBeInstanceOf(PhpTypedValues\Undefined\Alias\Undefined::class);
 });
+
+it('isEmpty is always false for BoolStandard', function (): void {
+    expect(BoolStandard::fromBool(true)->isEmpty())->toBeFalse()
+        ->and(BoolStandard::fromBool(false)->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Bool/FalseStandardTest.php b/tests/Unit/Bool/FalseStandardTest.php
@@ -100,3 +100,7 @@ public function __toString(): string
         ->and($fromArray)->toBeInstanceOf(Undefined::class)
         ->and($fromNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for FalseStandard', function (): void {
+    expect(FalseStandard::fromString('no')->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/DateTimeAtomTest.php b/tests/Unit/DateTime/DateTimeAtomTest.php
@@ -165,3 +165,8 @@ public function __toString(): string
         ->and($badArr)->toBeInstanceOf(Undefined::class)
         ->and($badNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for DateTimeAtom', function (): void {
+    $vo = DateTimeAtom::fromString('2025-01-02T03:04:05+00:00');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/DateTimeRFC3339ExtendedTest.php b/tests/Unit/DateTime/DateTimeRFC3339ExtendedTest.php
@@ -165,3 +165,8 @@ public function __toString(): string
         ->and($badArr)->toBeInstanceOf(Undefined::class)
         ->and($badNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for DateTimeRFC3339Extended', function (): void {
+    $vo = DateTimeRFC3339Extended::fromString('2025-01-02T03:04:05.000+00:00');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/DateTimeRFC3339Test.php b/tests/Unit/DateTime/DateTimeRFC3339Test.php
@@ -164,3 +164,8 @@ public function __toString(): string
         ->and($badArr)->toBeInstanceOf(Undefined::class)
         ->and($badNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for DateTimeRFC3339', function (): void {
+    $vo = DateTimeRFC3339::fromString('2025-01-02T03:04:05+00:00');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/DateTime/DateTimeW3CTest.php b/tests/Unit/DateTime/DateTimeW3CTest.php
@@ -164,3 +164,8 @@ public function __toString(): string
         ->and($badArr)->toBeInstanceOf(Undefined::class)
         ->and($badNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty is always false for DateTimeW3C', function (): void {
+    $vo = DateTimeW3C::fromString('2025-01-02T03:04:05+00:00');
+    expect($vo->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Float/FloatNonNegativeTest.php b/tests/Unit/Float/FloatNonNegativeTest.php
@@ -143,3 +143,11 @@
     $v = FloatNonNegative::fromString('10.5');
     expect($v->jsonSerialize())->toBe($v->value());
 });
+
+it('isEmpty returns false for FloatNonNegative', function (): void {
+    $a = new FloatNonNegative(0.0);
+    $b = FloatNonNegative::fromFloat(3.14);
+
+    expect($a->isEmpty())->toBeFalse()
+        ->and($b->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Float/FloatPositiveTest.php b/tests/Unit/Float/FloatPositiveTest.php
@@ -146,3 +146,11 @@ public function __toString(): string
         ->and($fromStringable)->toBeInstanceOf(FloatPositive::class)
         ->and($fromStringable->value())->toBe(1.23);
 });
+
+it('isEmpty returns false for FloatPositive', function (): void {
+    $a = new FloatPositive(0.1);
+    $b = FloatPositive::fromFloat(2.5);
+
+    expect($a->isEmpty())->toBeFalse()
+        ->and($b->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Float/FloatStandardTest.php b/tests/Unit/Float/FloatStandardTest.php
@@ -82,3 +82,11 @@ public function __toString(): string
         ->and($fromStringable)->toBeInstanceOf(FloatStandard::class)
         ->and($fromStringable->value())->toBe(1.23);
 });
+
+it('isEmpty returns false for FloatStandard', function (): void {
+    $a = new FloatStandard(-1.0);
+    $b = FloatStandard::fromFloat(0.0);
+
+    expect($a->isEmpty())->toBeFalse()
+        ->and($b->isEmpty())->toBeFalse();
+});
diff --git a/tests/Unit/Integer/IntegerNonNegativeTest.php b/tests/Unit/Integer/IntegerNonNegativeTest.php
@@ -164,3 +164,11 @@ public function __toString(): string
         ->and($badArr)->toBeInstanceOf(Undefined::class)
         ->and($badNull)->toBeInstanceOf(Undefined::class);
 });
+
+it('isEmpty returns false for IntegerNonNegative', function (): void {
+    $a = new IntegerNonNegative(0);
+    $b = IntegerNonNegative::fromInt(5);
+
+    expect($a->isEmpty())->toBeFalse()
+        ->and($b->isEmpty())->toBeFalse();
+});

Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,6 @@ public function count(): int`
`101`	`101`	`return count($this->value);`
`102`	`102`	`}`
`103`	`103`
`104`		`- /**`
`105`		`- * Return true if the array is empty, false otherwise.`
`106`		`- */`
`107`	`104`	`public function isEmpty(): bool`
`108`	`105`	`{`
`109`	`106`	`return $this->count() === 0;`
Original file line number	Diff line number	Diff line change
`@@ -121,4 +121,9 @@ public function __toString(): string`
`121`	`121`	`{`
`122`	`122`	`return $this->toString();`
`123`	`123`	`}`
	`124`	`+`
	`125`	`+ public function isEmpty(): bool`
	`126`	`+ {`
	`127`	`+ return false;`
	`128`	`+ }`
`124`	`129`	`}`
Original file line number	Diff line number	Diff line change
`@@ -125,4 +125,9 @@ public function __toString(): string`
`125`	`125`	`{`
`126`	`126`	`return $this->toString();`
`127`	`127`	`}`
	`128`	`+`
	`129`	`+ public function isEmpty(): bool`
	`130`	`+ {`
	`131`	`+ return false;`
	`132`	`+ }`
`128`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -105,4 +105,9 @@ public static function getFormat(): string`
`105`	`105`	`{`
`106`	`106`	`return static::FORMAT;`
`107`	`107`	`}`
	`108`	`+`
	`109`	`+ public function isEmpty(): bool`
	`110`	`+ {`
	`111`	`+ return false;`
	`112`	`+ }`
`108`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,4 +106,9 @@ public static function getFormat(): string`
`106`	`106`	`{`
`107`	`107`	`return static::FORMAT;`
`108`	`108`	`}`
	`109`	`+`
	`110`	`+ public function isEmpty(): bool`
	`111`	`+ {`
	`112`	`+ return false;`
	`113`	`+ }`
`109`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,4 +107,9 @@ public function __toString(): string`
`107`	`107`	`{`
`108`	`108`	`return $this->toString();`
`109`	`109`	`}`
	`110`	`+`
	`111`	`+ public function isEmpty(): bool`
	`112`	`+ {`
	`113`	`+ return false;`
	`114`	`+ }`
`110`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,4 +91,9 @@ public function __toString(): string`
`91`	`91`	`{`
`92`	`92`	`return $this->toString();`
`93`	`93`	`}`
	`94`	`+`
	`95`	`+ public function isEmpty(): bool`
	`96`	`+ {`
	`97`	`+ return false;`
	`98`	`+ }`
`94`	`99`	`}`