Add E2E tests for bi-directional scrolling in Thread (#2576)

Author: testableapple

StreamChatUITestsAppUITests/Pages/ThreadPage.swift

@@ -8,6 +8,7 @@ import XCTest
 class ThreadPage: MessageListPage {
 
     static var alsoSendInChannelCheckbox: XCUIElement { app.otherElements["CheckboxControl"] }
+    static var repliesCountLabel: XCUIElement { app.staticTexts["textLabel"] }
 
     enum NavigationBar {
 

StreamChatUITestsAppUITests/Robots/UserRobot+Asserts.swift

@@ -195,6 +195,27 @@ extension UserRobot {
         XCTAssertEqual(text, actualText, file: file, line: line)
         return self
     }
+    
+    @discardableResult
+    func assertOldestLoadedMessage(
+        isEqual: Bool,
+        to text: String,
+        file: StaticString = #filePath,
+        line: UInt = #line
+    ) -> Self {
+        if let topMessageCell = cells.lastMatch {
+            let message = attributes.text(in: topMessageCell).wait()
+            let actualText = message.text
+            if isEqual {
+                XCTAssertEqual(text, actualText, file: file, line: line)
+            } else {
+                XCTAssertNotEqual(text, actualText, file: file, line: line)
+            }
+        } else {
+            XCTFail("lastMessageCell cannot be found")
+        }
+        return self
+    }
 
     @discardableResult
     func assertPushNotification(
@@ -466,7 +487,7 @@ extension UserRobot {
         if deliveryStatus == .failed || deliveryStatus == nil {
             XCTAssertFalse(checkmark.exists, "Checkmark is visible", file: file, line: line)
         } else {
-            XCTAssertTrue(checkmark.wait(timeout: 10).exists, "Checkmark is not visible", file: file, line: line)
+            XCTAssertTrue(checkmark.wait(timeout: 15).exists, "Checkmark is not visible", file: file, line: line)
         }
 
         return self
@@ -675,7 +696,7 @@ extension UserRobot {
         XCTAssertEqual(quotedText, actualText)
         XCTAssertTrue(message.exists, "Quoted message was not showed")
         XCTAssertFalse(message.isEnabled, "Quoted message should be disabled")
-        XCTAssertTrue(message.isHittable, "Quoted message is not visible")
+        XCTAssertTrue(message.waitForHitPoint().isHittable, "Quoted message is not visible")
 
         if !replyText.isEmpty {
             let message = attributes.text(replyText, in: messageCell).wait()
@@ -795,13 +816,56 @@ extension UserRobot {
         at messageCellIndex: Int? = nil,
         file: StaticString = #filePath,
         line: UInt = #line
+    ) -> Self {
+        assertThreadReplyCountButton(at: messageCellIndex, replies: 0, file: file, line: line)
+    }
+    
+    @discardableResult
+    func assertThreadReplyCountButton(
+        at messageCellIndex: Int? = nil,
+        replies: Int,
+        file: StaticString = #filePath,
+        line: UInt = #line
     ) -> Self {
         let messageCell = messageCell(withIndex: messageCellIndex, file: file, line: line)
         let threadReplyCountButton = attributes.threadReplyCountButton(in: messageCell).wait()
         XCTAssertTrue(threadReplyCountButton.exists,
                       "There is no thread reply count button",
                       file: file,
                       line: line)
+        if replies > 0 {
+            let expectedText = "\(replies) Thread Replies"
+            XCTAssertEqual(expectedText, threadReplyCountButton.waitForText(expectedText).text)
+        }
+        return self
+    }
+    
+    @discardableResult
+    func assertThreadRepliesCountLabel(
+        _ count: Int,
+        file: StaticString = #filePath,
+        line: UInt = #line
+    ) -> Self {
+        let expectedLabel = "\(count) REPLIES"
+        let repliesCountLabel = ThreadPage.repliesCountLabel.waitForText(expectedLabel).text
+        XCTAssertEqual(repliesCountLabel, repliesCountLabel, file: file, line: line)
+        return self
+    }
+    
+    @discardableResult
+    func assertParentMessageInThread(
+        withText text: String,
+        isLoaded: Bool,
+        file: StaticString = #filePath,
+        line: UInt = #line
+    ) -> Self {
+        if isLoaded {
+            XCTAssertTrue(ThreadPage.repliesCountLabel.wait().exists, file: file, line: line)
+            assertOldestLoadedMessage(isEqual: true, to: text)
+        } else {
+            XCTAssertFalse(ThreadPage.repliesCountLabel.exists, file: file, line: line)
+            assertOldestLoadedMessage(isEqual: false, to: text)
+        }
         return self
     }
 }

StreamChatUITestsAppUITests/Robots/UserRobot.swift

@@ -73,7 +73,7 @@ extension UserRobot {
 
     @discardableResult
     func openContextMenu(messageCellIndex: Int = 0) -> Self {
-        messageCell(withIndex: messageCellIndex).safePress(forDuration: 1)
+        messageCell(withIndex: messageCellIndex).waitForHitPoint().safePress(forDuration: 1)
         return self
     }
 

StreamChatUITestsAppUITests/Tests/Message Delivery Status/MessageDeliveryStatus_Tests.swift

@@ -346,7 +346,7 @@ extension MessageDeliveryStatus_Tests {
             userRobot.replyToMessageInThread(threadReply)
         }
         AND("participant reads the user's thread reply") {
-            participantRobot.readMessageAfterDelay()
+            participantRobot.readMessageInThreadAfterDelay()
         }
         THEN("user spots double checkmark below the message") {
             userRobot.assertMessageDeliveryStatus(.read)
@@ -356,8 +356,10 @@ extension MessageDeliveryStatus_Tests {
         }
     }
 
-    func test_doubleCheckmarkShownInThreadReply_whenNewParticipantAdded() {
+    func test_doubleCheckmarkShownInThreadReply_whenNewParticipantAdded() throws {
         linkToScenario(withId: 154)
+        
+        try XCTSkipIf(ProcessInfo().operatingSystemVersion.majorVersion == 12, "Flaky on iOS 12")
 
         GIVEN("user opens the channel") {
             userRobot
@@ -398,7 +400,7 @@ extension MessageDeliveryStatus_Tests {
             userRobot.replyToMessageInThread(threadReply)
         }
         AND("thread reply is read by participant") {
-            participantRobot.readMessageAfterDelay()
+            participantRobot.readMessageInThreadAfterDelay()
             userRobot
                 .assertMessageDeliveryStatus(.read)
                 .assertMessageReadCount(readBy: 1)

StreamChatUITestsAppUITests/Tests/MessageList_Tests.swift

@@ -210,9 +210,13 @@ final class MessageList_Tests: StreamTestCase {
         let isIpad = UIDevice.current.userInterfaceIdiom == .pad
         let typingIndicatorTimeout = isIpad ? 10 : XCUIElement.waitTimeout
         let typingEventsTimeout: Double = 3
+        let message = "message"
 
         GIVEN("user opens the channel") {
-            userRobot.login().openChannel()
+            userRobot
+                .login()
+                .openChannel()
+                .sendMessage(message)
         }
         WHEN("participant starts typing") {
             participantRobot.wait(typingEventsTimeout).startTyping()