-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Labels
3.x4.xvalidationFeature to make things safe and predictableFeature to make things safe and predictable
Milestone
Description
Problem
As discussed on Discord today (here), if we want parity between the Thunderstore manifest.json and our current one, then we need to ensure that dependencies have version strings, eg:
"dependencies": [
"Darkly77-ContentLoader-5.0.0"
]
But we also need to support dependencies without them, because Brotato's workshop support has launched without this requirement. This means that this also needs to be valid (like it currently is):
"dependencies": [
"Darkly77-ContentLoader"
]
Suggestion
- Add a new mod ID validation check to ensure that a version string is present.
- If they are missing, trigger a fatal error in the editor (to notify the mod creator).
- However, outside of the editor, allow normal execution of the code (ie. proceed to the next step of validation, below).
- Keep the legacy validation, which doesn't check for the version string.
- An error here should prevent the mod from loading, whether you'r in the editor or not (just like it currently does).
Metadata
Metadata
Assignees
Labels
3.x4.xvalidationFeature to make things safe and predictableFeature to make things safe and predictable