-
Notifications
You must be signed in to change notification settings - Fork 2
Make package version names consistent. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyoklee
wants to merge
29
commits into
HDFGroup:main
Choose a base branch
from
hyoklee:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6ade2a8
cleaned up code. added mpicc/mpicpp & env. vars.
hyoklee c713131
Merge branch 'HDFGroup:main' into main
hyoklee f98c73c
Clean up code.
hyoklee f63d117
added adios2 VOL in vol-tests.
hyoklee 9d9c4b6
Test vol-tests with cache VOL using GitHub Actions.
hyoklee 6897dea
Add szip dependency.
hyoklee cd8b7bf
Turn off testing. Skip hdf5-hpc-io.
hyoklee 3f81b38
Turn off testing. Skip hdf5-hpc-io.
hyoklee 45737d8
Install openmpi by apt-get.
hyoklee decaf0f
Switch preferred repo to official one.
hyoklee 8c5a8c6
Update spack.yml
hyoklee 4401d16
Removed unused variable.
hyoklee 779c630
OESS-155: Add GPU VFD package.
hyoklee f97898f
Merge pull request #2 from hyoklee/OESS-155-hdf5-vfd-gds
hyoklee 1b27ed0
OESS-186: Test spack external find.
hyoklee f0db051
OESS-186: Test pre-defined external.
hyoklee 89d4317
OESS-186: Add PATH environment variable.
hyoklee 5a22665
Update vfd-gds.yml
hyoklee c29c2a4
Update vfd-gds.yml
hyoklee da78ae7
OESS-186: Test master branch.
hyoklee 17897cc
OESS-186: Add export PATH.
hyoklee 44cfbea
OESS-168: Install dependencies.
hyoklee 39c91dc
OESS-186: Sync hdf5 with origin.
hyoklee ea5d70e
Merge branch 'main' of https://github.com/hyoklee/hdf-spack
hyoklee d8df9ea
OESS-186: Add apt update.
hyoklee 171c9a9
Address @lrknox review for PR #12.
hyoklee 2b1c006
OESS-186: Build with apt packages.
hyoklee 86b63e4
Change the default version to 1.0.1.
hyoklee c021720
Update version for tar.gz package.
hyoklee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,16 +9,20 @@ class Hdf5VolAsync(CMakePackage): | |
| """This package enables asynchronous IO in HDF5.""" | ||
|
|
||
| homepage = "https://sdm.lbl.gov/" | ||
| # hpc-io hasn't accepted the pull request for CMakeLists.txt yet. | ||
| # git = "https://github.com/hpc-io/vol-async" | ||
| git = "https://github.com/hyoklee/vol-async" | ||
| git = "https://github.com/hpc-io/vol-async" | ||
| maintainers = ['hyoklee'] | ||
|
|
||
| version('develop', branch='develop') | ||
| version('hyoklee.develop', | ||
| branch='develop', | ||
| git='https://github.com/hyoklee/vol-async', preferred=True) | ||
| version('local.develop', branch='develop', | ||
| git='file:///scr/hyoklee/src/vol-async') | ||
|
|
||
| depends_on('argobots@main') | ||
| # depends_on('hdf5-hpc-io') | ||
| depends_on('hdf5-cmake') | ||
| depends_on('hdf5-hpc-io') | ||
| # Use the following if you want to use HDFGroup/[email protected] instead. | ||
| # depends_on('[email protected]+mpi+threadsafe') | ||
|
|
||
| def cmake_args(self): | ||
| """Populate cmake arguments for HDF5 VOL.""" | ||
|
|
@@ -27,6 +31,16 @@ def cmake_args(self): | |
| args = [ | ||
| '-DBUILD_SHARED_LIBS:BOOL=ON', | ||
| '-DBUILD_TESTING:BOOL=ON' | ||
| '-DCMAKE_C_COMPILER=mpicc', | ||
| '-DCMAKE_CXX_COMPILER=mpicxx', | ||
| ] | ||
|
|
||
| return args | ||
|
|
||
|
|
||
| def setup_environment(self, spack_env, run_env): | ||
| spack_env.set('HDF5_PLUGIN_PATH', self.build_directory+'/lib') | ||
| spack_env.set('HDF5_VOL_CONNECTOR', | ||
| 'async under_vol=0\;under_info={}') | ||
| spack_env.set('LD_PRELOAD', self.spec['argobots'].prefix+'/lib/libabt.so') | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,21 +14,34 @@ class Hdf5VolTests(CMakePackage): | |
|
|
||
| maintainers = ['hyoklee'] | ||
|
|
||
| version('master', preferred=True) | ||
| variant('vol-async', default=True, description='Enable async VOL') | ||
| version('master', commit='9a147d3') | ||
| version('hyoklee.master', | ||
| git='https://github.com/hyoklee/vol-tests', preferred=True) | ||
| version('local.master', | ||
| git='file:///Users/hyoklee/src/vol-tests') | ||
| variant('vol-async', default=False, description='Enable async VOL') | ||
| variant('vol-cache', default=False, description='Enable cache VOL') | ||
| variant('vol-external-passthrough', default=False, | ||
| description='Enable external pass-through VOL') | ||
| variant('vol-log', default=False, | ||
| description='Enable log-based VOL') | ||
| variant('vol-adios2', default=False, | ||
| description='Enable ADIOS2 VOL') | ||
| variant('vol-rest', default=False, | ||
| description='Enable REST VOL') | ||
|
|
||
| variant('async', default=True, description='Enable parallel tests.') | ||
| variant('parallel', default=True, description='Enable async API tests.') | ||
| variant('part', default=True, | ||
| description='Enable building the main test executable.') | ||
| depends_on('szip', when='+parallel') | ||
| depends_on('szip') | ||
| depends_on('hdf5-vol-async', when='+vol-async') | ||
| depends_on('hdf5-vol-cache', when='+vol-cache') | ||
| depends_on('hdf5-vol-external-passthrough', | ||
| when='+vol-external-passthrough') | ||
| depends_on('hdf5-vol-log', when='+vol-log') | ||
| depends_on('adios2+shared+hdf5 ^[email protected]', when='+vol-adios2') | ||
| depends_on('hdf5-vol-rest', when='+vol-rest') | ||
|
|
||
| def cmake_args(self): | ||
| args = [] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
descriptions in 2 lines above appear to be reversed