fixed most important puppet lint issues

Author: kreczko

manifests/init.pp

@@ -17,8 +17,6 @@
 # will create a rule :
 # rule deny { subject-issuer = 'CN=bad guys' }
 class argus (
-  $open_firewall = false,
-
   #the argus pap server used by pdp
   $pap_server,
   #the argus pdp server used by pep
@@ -31,8 +29,6 @@
 
   #this will setup the voms related things :
   $supported_vos,
-  #this will create argus "permit" rules for those VOs if true
-  $supported_vos_allowed = true,
 
   # site name is required
   $sitename,
@@ -43,27 +39,35 @@
   # pep params
   $pepd_port,
   $pepd_admin_port,
-  $pepd_pass = randompass(),
 
   # pdp params
   $pdps_port,
   $pdp_port,
   $pdp_admin_port,
-  $pdp_pass = randompass(),
   $pdp_retention_interval,
 
   # pap parameters
   $pap_port,
   $pap_shutdown_port,
-  $pap_shutdown_command = randompass(),
-
 
   # central banning setup
   $centralbanning_dn,
   $centralbanning_hostname,
   $centralbanning_port,
   $centralbanning_public,
   $poll_interval,
+  #files
+  $grid_mapfile,
+  $grid_mapdir,
+  $group_mapfile,
+
+  $open_firewall = false,
+  #this will create argus "permit" rules for those VOs if true
+  $supported_vos_allowed = true,
+
+  $pepd_pass = randompass(),
+  $pdp_pass = randompass(),
+  $pap_shutdown_command = randompass(),
 
   $service_name      = $::fqdn ,
 
@@ -105,13 +109,6 @@
   # ...
 
   $pap_rules         = {},
-
-  #files
-  $grid_mapfile,
-  $grid_mapdir,
-  $group_mapfile,
-
-
   ) {
 
   $pap_service_dn    = "${site_base_dn}=${service_name}"

manifests/servicecert.pp

@@ -1,4 +1,5 @@
 class argus::servicecert inherits argus::params {
+  $service_name = $::argus::service_name
   if $service_name == $::fqnd {
     # we can use the puppet autogenerated certificate
     class {'hostcertificate::gridcertificate':}