Truncated responses

[cergfix]

There appears to be a problem with

//read response data
ByteBuffer buffer = ByteBuffer.allocate(10240);
connection.read(buffer);
buffer.flip();

Sometimes, when the response is quite big, it's being truncated even if ByteBuffer.allocate is set to a higher value.

Any ideas? I will try to dig as much debug data as possible for this.

[serphen]

Hi,

The problem is because of multiplexed STDOUT and STDERR. When a STDERR answer comes in the middle it breaks everything.

Steps to reproduce:

Create a PHP file with:

<a href="">....</a>
</li>
<li>
<a href="">....</a>
</li>
<li>BREAKME
<?php
fprintf(stderr, "TROLOLOLO");
?>
<a href="">....</a>
</li>END

The answer will stop at BREAKME instead of stopping at END

The problem comes from the line: https://github.com/Happyr/fcgi4j/blob/master/src/com/googlecode/fcgi4j/FCGIConnection.java#L484
which is early breaking (it breaks at the first non-STDOUT packet).

Proposed solution (I have refactored a bit read() as well to be consistent with read with ByteBuffers):

    @Override
    public int read(ByteBuffer dst) throws IOException {
        readyRead();

        int read = 0;

        int available = 0, padding = 0;

        outer:
        if (true) {
            if (available == 0) {
                read += readBufferedData(dst);
            } else {
                read += readStdoutData(dst, available, padding);
            }

            while (dst.hasRemaining()) {
                FCGIHeader header = readHeader();

    ----->            if ((header.getType() == FCGIHeaderType.FCGI_STDOUT || header.getType() == FCGIHeaderType.FCGI_STDERR) && header.getLength() != 0) {
                    int currentRead = readStdoutData(dst, header.getLength(), header.getPadding());

                    available = header.getLength() - currentRead;
                    padding = header.getPadding();

                    read += currentRead;
                } else {
                    if (header.getType() == FCGIHeaderType.FCGI_END_REQUEST) {
                        finishRequest(header);
                        break outer;
                    }
                }
            }
        }

        if (available != 0) {
            bufferStdoutData(available, padding);
        }

        return read;
    }

[Nyholm]

Fantastic! Thank you for reporting this bug and thank you @serphen for providing a fix. Would you mind sending a pull request with the changes?