Added error Page #47
Open
Added error Page #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshCasper
requested changes
Mar 7, 2021
| import Profile from "./Pages/UserProfile"; | ||
| import profileData from "./Data/profileData.json"; | ||
| import "./styles.css"; | ||
| import NotFoundPage from './pages/NotFoundPage'; |
Owner
There was a problem hiding this comment.
Change this line to import Error from './Error.js';
| <Switch> | ||
| <Route path="/profile" component={Profile} /> | ||
| <Redirect to="/profile" /> | ||
| <Route component={NotFoundPage} /> |
Owner
There was a problem hiding this comment.
Change this line to <Route component={Error} />
| // import Logo from '../logo.png'; | ||
| import React from "react"; | ||
| import {NavLink} from "react-router-dom"; | ||
| import Logo from './design/error-screen/sreens/error-sreen-desktop.png' |
Owner
There was a problem hiding this comment.
Imports outside of the src directory are not yet supported.
| // import Logo from '../logo.png'; | ||
| import React from "react"; | ||
| import {NavLink} from "react-router-dom"; | ||
| import Logo from './design/error-screen/sreens/error-sreen-desktop.png' |
Owner
There was a problem hiding this comment.
To add an Image, create a directory called assets, in the src, add the image there and reference it from there.
| <BrowserRouter> | ||
| <Header /> | ||
| <Switch> | ||
| <Route path="/profile" component={Profile} /> |
Owner
There was a problem hiding this comment.
Make it as a persisted route. Just change this to <Route path="/profile" component={Profile} exact />
Owner
|
Hi @madhup01 Are there any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @HarshCasper
this is PR for #38