Cleanup

Author: Him188

BridgeFeatures.md

@@ -122,7 +122,7 @@ Reported when `@JvmBlockingBridge` is applied to a function which either:
 - is in `inline` class
 - has parameter types or return type that is `inline` classes
 
-#### `UNSUPPORTED_BLOCKING_BRIDGES_IN_INTERFACE`
+#### `INTERFACE_NOT_SUPPORTED`
 Reported when `@JvmBlockingBridge` is applied to a function in an interface, and the JVM target is below 8
 
 ### Warnings
@@ -133,7 +133,5 @@ Reported when `@JvmBlockingBridge` is applied to a function which is either:
 - in `private` classes, interfaces, enums or objects.
 
 #### `OVERRIDING_GENERATED_BLOCKING_BRIDGE`
+*(TODO)*  
 Reported when overriding generated bridges from Java or Kotlin.
-
-#### `IMPLICIT_OVERRIDE_BY_JVM_BLOCKING_BRIDGE`
-Reported when bridges are overriding or hiding a super member.

README.md

@@ -5,6 +5,8 @@
 Kotlin compiler plugin for generating blocking bridges for calling suspend functions from Java with minimal effort
 
 ## Screenshots
+<details>
+<summary>Click to expand</summary>
 Kotlin suspend functions:  
 ![image_2.png](https://i.loli.net/2020/08/08/d5cYwhQqeuj8Nvf.png)
 
@@ -13,6 +15,7 @@ Bridge method calls:
 
 Documentation and navigation support:  
 ![image_1](https://i.loli.net/2020/08/08/koCl6zj4OAJ5aUN.png)
+</details>
 
 ### Motivation
 Kotlin suspend function is compiled with an additional `$completion: Continuation` parameter, making it hard to call from Java, so we often make extra effort to simplify calling.

compiler-plugin/src/main/java/net/mamoe/kjbb/compiler/diagnostic/BlockingBridgeErrors.java

@@ -14,7 +14,7 @@ public interface BlockingBridgeErrors {
     // DiagnosticFactory0<PsiElement> PLUGIN_IS_NOT_ENABLED = DiagnosticFactory0.create(WARNING);
     DiagnosticFactory0<PsiElement> INAPPLICABLE_JVM_BLOCKING_BRIDGE = DiagnosticFactory0.create(ERROR);
     DiagnosticFactory1<PsiElement, DeclarationDescriptor> INLINE_CLASSES_NOT_SUPPORTED = DiagnosticFactory1.create(ERROR);
-    DiagnosticFactory0<PsiElement> INTERFACE_NOT_SUPPORTED_BELOW_JAVA8 = DiagnosticFactory0.create(ERROR);
+    DiagnosticFactory0<PsiElement> INTERFACE_NOT_SUPPORTED = DiagnosticFactory0.create(ERROR);
     DiagnosticFactory0<PsiElement> REDUNDANT_JVM_BLOCKING_BRIDGE_ON_PRIVATE_DECLARATIONS = DiagnosticFactory0.create(WARNING);
 
     DiagnosticFactory1<PsiElement, String> OVERRIDING_GENERATED_BLOCKING_BRIDGE = DiagnosticFactory1.create(WARNING);

compiler-plugin/src/main/kotlin/net/mamoe/kjbb/compiler/backend/jvm/analyzing.kt

@@ -49,7 +49,7 @@ sealed class BlockingBridgeAnalyzeResult(
     class InterfaceNotSupported(
         private val inspectionTarget: PsiElement,
     ) : BlockingBridgeAnalyzeResult(false) {
-        override fun createDiagnostic(): Diagnostic? = INTERFACE_NOT_SUPPORTED_BELOW_JAVA8.on(inspectionTarget)
+        override fun createDiagnostic(): Diagnostic? = INTERFACE_NOT_SUPPORTED.on(inspectionTarget)
     }
 
     class InlineClassesNotSupported(

compiler-plugin/src/main/kotlin/net/mamoe/kjbb/compiler/diagnostic/BlockingBridgeErrorsRendering.kt

@@ -36,7 +36,7 @@ object BlockingBridgeErrorsRendering : DefaultErrorMessages.Extension {
         )
 
         put(
-            INTERFACE_NOT_SUPPORTED_BELOW_JAVA8,
+            INTERFACE_NOT_SUPPORTED,
             "Interface is not supported for jvm target lower than 8"
         )
     }