Skip to content

Conversation

@abh
Copy link

@abh abh commented Dec 6, 2025

https://lists.gnupg.org/pipermail/gnupg-announce/2025q4/000499.html

https://www.gnupg.org says

We are pleased to announce the availability of a new GnuPG release: Version 2.5.14. This release adds new features and fixes a couple of bugs. New Debian packages are also also availabe; see repos.gnupg.org.

Note that this 2.5 series is fully supported and thus ready for production use. This means we won't break anything but may add some more features before 2.6."

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://lists.gnupg.org/pipermail/gnupg-announce/2025q4/000499.html

https://www.gnupg.org says 

> We are pleased to announce the availability of a new GnuPG release: Version 2.5.14. This release adds new features and fixes a couple of bugs. New Debian packages are also also availabe; see repos.gnupg.org.
> 
> Note that this 2.5 series is fully supported and thus ready for production use. This means we won't break anything but may add some more features before 2.6."
Copilot AI review requested due to automatic review settings December 6, 2025 02:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GnuPG formula to recognize version 2.5.x as a stable production release, following the official announcement that the 2.5 series is now fully supported. The change modifies the livecheck regex pattern to include minor versions ending in 5.

Key Changes

  • Modified the livecheck regex to include version 2.5.x by adding "5" to the character class of acceptable minor version endings

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@p-linnane p-linnane added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Dec 6, 2025
@p-linnane p-linnane requested a review from samford December 6, 2025 04:20
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the linked comment and the quotation in the PR description, 2.4 is still referenced as the stable version and the announcement contains indications that 2.5.14 is still a development version. To support that, the download page lists 2.5.14 as the "devel" version, as expected.

This doesn't seem to indicate that upstream has changed their even/odd minor stable/devel versioning approach. The announcement commentary reads to me as, "This is a development release but it's pretty stable even though it isn't a stable release, so don't be afraid to use it in production if you would like."

Unless upstream has explicitly altered their version scheme such that minor versions ending in 5 (e.g., 5, 15, 25, etc.) are stable, changing the livecheck block regex in this way doesn't seem correct to me.

@fxcoudert
Copy link
Member

I agree with @samford. Also, the wording of the 2.5.14 release announcement is the same as previous 2.5.x versions, so no reason to change.

Thanks @abh for raising the question and proposing the PR.

@fxcoudert fxcoudert closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants