added validation to api response

Author: sophia-chen-ttd

uid2_client/identity_map_v3_response.py

@@ -57,15 +57,19 @@ def __init__(self, status: str, body: Dict[Literal['email_hash', 'phone_hash'],
 
     @classmethod
     def from_json(cls, data) -> 'ApiResponse':
+        if not set(data['body'].keys()).issubset(['email', 'phone', 'email_hash', 'phone_hash']):
+            raise ValueError("api response body does not contain correct keys")
+
         api_body: Dict[Literal['email_hash', 'phone_hash'], List['ApiIdentity']] = {
-            'email_hash': [ApiIdentity.from_json(item) for item in data.get('body').get('email_hash', [])] if data.get('body').get('email_hash') else [],
-            'phone_hash': [ApiIdentity.from_json(item) for item in data.get('body').get('phone_hash', [])] if data.get('body').get('phone_hash') else [],
+            'email_hash': [ApiIdentity.from_json(item) for item in data['body']['email_hash']] if data['body'].get('email_hash') else [],
+            'phone_hash': [ApiIdentity.from_json(item) for item in data['body']['phone_hash']] if data['body'].get('phone_hash') else [],
         }
         return cls(
-            status=data.get("status"),
+            status=data['status'],
             body=api_body
         )
 
+
 class ApiIdentity:
     def __init__(self, current_uid: Optional[str], previous_uid: Optional[str], 
                  refresh_from_seconds: Optional[int], error: Optional[str]):