Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Commit 78a2a8f

Browse files
authored
Merge pull request #27 from IBM/fixes
Fix legacy children’ heights and avoid assumed flexbox
2 parents 118abe3 + 1092aa1 commit 78a2a8f

28 files changed

+94
-137
lines changed
Binary file not shown.

examples/bootstrap/css-gridish/css/bootstrap-grid-legacy.css

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ body {
3030
flex-wrap: wrap;
3131
position: relative; }
3232
.bootstrap-grid > * {
33-
box-sizing: border-box;
34-
height: 100%; }
33+
box-sizing: border-box; }
3534
.bootstrap-grid > * :last-child,
3635
.bootstrap-grid > * :last-child > :last-child,
3736
.bootstrap-grid > * :last-child > :last-child > :last-child {
@@ -49,8 +48,12 @@ body {
4948
.bootstrap-grid > * {
5049
width: initial; } }
5150

51+
@supports (display: grid) {
52+
.bootstrap-grid > * {
53+
height: 100%; } }
54+
5255
[class*="bootstrap-grid__col--sm--"] {
53-
display: flex; }
56+
display: block; }
5457

5558
.bootstrap-grid__col--sm--0,
5659
.bootstrap-grid__col--sm--0--only {
@@ -319,9 +322,9 @@ body {
319322

320323
@media (min-width: 100rem) {
321324
.bootstrap-grid__col--sm--0--only {
322-
display: flex; }
325+
display: block; }
323326
[class*="bootstrap-grid__col--xl--"] {
324-
display: flex; }
327+
display: block; }
325328
.bootstrap-grid__col--xl--0,
326329
.bootstrap-grid__col--xl--0--only {
327330
display: none; }

examples/bootstrap/css-gridish/css/bootstrap-grid-legacy.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/bootstrap/css-gridish/css/bootstrap-grid.css

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ body {
2424
flex-wrap: wrap;
2525
position: relative; }
2626
.bootstrap-grid > * {
27-
box-sizing: border-box;
28-
height: 100%; }
27+
box-sizing: border-box; }
2928
.bootstrap-grid > * :last-child,
3029
.bootstrap-grid > * :last-child > :last-child,
3130
.bootstrap-grid > * :last-child > :last-child > :last-child {
@@ -34,6 +33,10 @@ body {
3433
[class*="bootstrap-padding"] {
3534
box-sizing: border-box; }
3635

36+
@supports (display: grid) {
37+
.bootstrap-grid > * {
38+
height: 100%; } }
39+
3740
.bootstrap-padding {
3841
padding: calc(30px / 2); }
3942

0 commit comments

Comments
 (0)