Handle returned error messages (#106)

Signed-off-by: Mayank Sachan <[email protected]>

Author: mssachan

controllers/ibmobjectcsi_controller.go

@@ -296,7 +296,9 @@ func (r *IBMObjectCSIReconciler) updateStatus(instance *crutils.IBMObjectCSI, or
 			}
 
 			if !r.areAllPodImagesSynced(controllerDeployment, controllerPod) {
-				_ = r.restartControllerPodfromDeployment(logger, controllerDeployment, controllerPod)
+				if err := r.restartControllerPodfromDeployment(logger, controllerDeployment, controllerPod); err != nil {
+					logger.Error(err, "failed to restart controller pod from deployment")
+				}
 			}
 		}
 		phase = objectdriverv1alpha1.DriverPhaseCreating

controllers/ibmobjectcsi_controller_test.go

@@ -1031,6 +1031,8 @@ func TestIBMObjectCSIReconcile(t *testing.T) {
 func TestIBMObjectCSISetupWithManager(t *testing.T) {
 	t.Run("Positive: Successful", func(t *testing.T) {
 		ibmObjectCSIReconciler := &IBMObjectCSIReconciler{}
-		_ = ibmObjectCSIReconciler.SetupWithManager(nil)
+		if err := ibmObjectCSIReconciler.SetupWithManager(nil); err != nil {
+			TestLog.Error(err, "failed to setup controller with nanager")
+		}
 	})
 }

controllers/recoverstalevolume_controller_test.go

@@ -435,7 +435,9 @@ func TestRecoverStaleVolumeReconcile(t *testing.T) {
 func TestRecoverStaleVolumeSetupWithManager(t *testing.T) {
 	t.Run("Positive: Successful", func(t *testing.T) {
 		recoverStaleVolumeReconciler := &RecoverStaleVolumeReconciler{}
-		_ = recoverStaleVolumeReconciler.SetupWithManager(nil)
+		if err := recoverStaleVolumeReconciler.SetupWithManager(nil); err != nil {
+			TestLog.Error(err, "failed to setup controller with nanager")
+		}
 	})
 }