Skip to content

Commit 458e980

Browse files
committed
resolved travis issue
Signed-off-by: Renuka <[email protected]>
1 parent 06de369 commit 458e980

File tree

2 files changed

+7
-49
lines changed

2 files changed

+7
-49
lines changed

file/provider/create_volume.go

Lines changed: 7 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,14 @@ const (
3333
minSize = 10 //10 GB
3434
maxSize = 16000 //16 TB
3535
customProfile = "custom-iops"
36-
<<<<<<< Updated upstream
3736
)
3837

3938
var (
4039
SupportedProfiles = []string{"dp2", "rfs"}
4140
IOPSAllowedProfiles = []string{"dp2"}
4241
BandwidthAllowedProfiles = []string{"rfs"}
43-
=======
44-
//dp2Profile = "dp2"
45-
>>>>>>> Stashed changes
4642
)
4743

48-
var Profiles = []string{"dp2", "rfs"}
49-
5044
// CreateVolume creates file share
5145
func (vpcs *VPCSession) CreateVolume(volumeRequest provider.Volume) (volumeResponse *provider.Volume, err error) {
5246
vpcs.Logger.Debug("Entry of CreateVolume method...")
@@ -71,7 +65,7 @@ func (vpcs *VPCSession) CreateVolume(volumeRequest provider.Volume) (volumeRespo
7165
AccessControlMode: volumeRequest.AccessControlMode,
7266
ResourceGroup: &resourceGroup,
7367
Profile: &models.Profile{
74-
Name: volumeRequest.Profile.Name,
68+
Name: volumeRequest.VPCVolume.Profile.Name,
7569
},
7670
Bandwidth: func() *int64 {
7771
profile := volumeRequest.VPCVolume.Profile.Name
@@ -123,8 +117,8 @@ func (vpcs *VPCSession) CreateVolume(volumeRequest provider.Volume) (volumeRespo
123117
}
124118

125119
var encryptionKeyCRN string
126-
if volumeRequest.VolumeEncryptionKey != nil && len(volumeRequest.VolumeEncryptionKey.CRN) > 0 {
127-
encryptionKeyCRN = volumeRequest.VolumeEncryptionKey.CRN
120+
if volumeRequest.VPCVolume.VolumeEncryptionKey != nil && len(volumeRequest.VPCVolume.VolumeEncryptionKey.CRN) > 0 {
121+
encryptionKeyCRN = volumeRequest.VPCVolume.VolumeEncryptionKey.CRN
128122
shareTemplate.EncryptionKey = &models.EncryptionKey{CRN: encryptionKeyCRN}
129123
}
130124

@@ -201,7 +195,6 @@ func validateVolumeRequest(volumeRequest provider.Volume) (models.ResourceGroup,
201195
if volumeRequest.Iops != nil {
202196
iops = ToInt64(*volumeRequest.Iops)
203197
}
204-
<<<<<<< Updated upstream
205198

206199
if volumeRequest.Bandwidth != nil {
207200
bandwidth = ToInt64(*volumeRequest.Bandwidth)
@@ -226,35 +219,14 @@ func validateVolumeRequest(volumeRequest provider.Volume) (models.ResourceGroup,
226219

227220
if volumeRequest.VPCVolume.ResourceGroup == nil {
228221
return resourceGroup, iops, bandwidth, userError.GetUserError("EmptyResourceGroup", nil)
229-
=======
230-
if volumeRequest.Profile == nil {
231-
return resourceGroup, iops, userError.GetUserError("VolumeProfileEmpty", nil)
232-
}
233-
// if volumeRequest.VPCVolume.Profile.Name != customProfile && volumeRequest.VPCVolume.Profile.Name != dp2Profile && iops > 0 {
234-
// return resourceGroup, iops, userError.GetUserError("VolumeProfileIopsInvalid", nil)
235-
// }
236-
237-
if volumeRequest.Profile.Name != customProfile && !contains(Profiles, volumeRequest.Profile.Name) && iops > 0 {
238-
return resourceGroup, iops, userError.GetUserError("VolumeProfileIopsInvalid", nil)
239-
}
240-
241-
// validate and add resource group ID or Name whichever is provided by user
242-
if volumeRequest.ResourceGroup == nil {
243-
return resourceGroup, iops, userError.GetUserError("EmptyResourceGroup", nil)
244-
}
245-
246-
// validate and add resource group ID or Name whichever is provided by user
247-
if len(volumeRequest.ResourceGroup.ID) == 0 && len(volumeRequest.ResourceGroup.Name) == 0 {
248-
return resourceGroup, iops, userError.GetUserError("EmptyResourceGroupIDandName", nil)
249-
>>>>>>> Stashed changes
250222
}
251223

252-
if len(volumeRequest.ResourceGroup.ID) > 0 {
253-
resourceGroup.ID = volumeRequest.ResourceGroup.ID
224+
if len(volumeRequest.VPCVolume.ResourceGroup.ID) > 0 {
225+
resourceGroup.ID = volumeRequest.VPCVolume.ResourceGroup.ID
254226
}
255-
if len(volumeRequest.ResourceGroup.Name) > 0 {
227+
if len(volumeRequest.VPCVolume.ResourceGroup.Name) > 0 {
256228
// get the resource group ID from resource group name as Name is not supported by RIaaS
257-
resourceGroup.Name = volumeRequest.ResourceGroup.Name
229+
resourceGroup.Name = volumeRequest.VPCVolume.ResourceGroup.Name
258230
}
259231

260232
return resourceGroup, iops, bandwidth, nil

file/provider/update_volume.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ func (vpcs *VPCSession) UpdateVolume(volumeTemplate provider.Volume) error {
6262
return userError.GetUserError("VolumeNotInValidState", err, volumeTemplate.VolumeID)
6363
}
6464

65-
<<<<<<< Updated upstream
6665
vpcs.Logger.Info("Volume got valid (stable) state", zap.Reflect("etag", etag))
6766

6867
// Tag check using new map-based tags
@@ -101,19 +100,6 @@ func (vpcs *VPCSession) UpdateVolume(volumeTemplate provider.Volume) error {
101100
if !shouldUpdate {
102101
vpcs.Logger.Info("No changes detected, skipping update call")
103102
return nil
104-
=======
105-
//If tags are equal then skip the UpdateFileShare RIAAS API call
106-
if ifTagsEqual(existShare.UserTags, volumeTemplate.Tags) {
107-
vpcs.Logger.Info("There is no change in user tags for volume, skipping the updateVolume for VPC IaaS... ", zap.Reflect("existShare", existShare.UserTags), zap.Reflect("volumeRequest", volumeTemplate.Tags))
108-
return nil
109-
}
110-
111-
//Append the existing tags with the requested input tags
112-
existShare.UserTags = append(existShare.UserTags, volumeTemplate.Tags...)
113-
114-
volume := &models.Share{
115-
UserTags: existShare.UserTags,
116-
>>>>>>> Stashed changes
117103
}
118104

119105
vpcs.Logger.Info("Calling VPC provider for volume UpdateVolumeWithTags...",

0 commit comments

Comments
 (0)