Adding support for GetSecurityGroupByName

Signed-off-by: Sameer Shaikh <[email protected]>

Author: sameshai

common/messages/messages_en.go

@@ -175,28 +175,28 @@ var messagesEn = map[string]util.Message{
 		Description: "Unable to fetch list of subnet.",
 		Type:        util.RetrivalFailed,
 		RC:          500,
-		Action:      "Unable to list subnet. Run 'ibmcloud is subnets' to list available subnets in your account.",
+		Action:      "Unable to list subnet. Target to appropriate region 'ibmcloud target -r <region>' and verify if 'ibmcloud is subnets' is returning the subnets. If it is not returning then raise ticket for VPC team else raise ticket for IKS team.",
 	},
 	"SubnetFindFailedWithZoneAndSubnetID": {
 		Code:        "SubnetFindFailedWithZoneAndSubnetID",
 		Description: "A subnet with the specified zone '%s' and available cluster subnet list '%s' could not be found.",
 		Type:        util.RetrivalFailed,
 		RC:          404,
-		Action:      "Verify that the subnet from the cluster subnet list exists. Run 'ibmcloud is subnets' to list available subnets in your account.",
+		Action:      "Verify that the subnet from the cluster subnet list exists. Target to appropriate region 'ibmcloud target -r <region>' and verify if 'ibmcloud is subnets' is returning the subnets. If it is not returning the matching subnet from the cluster subnet list then raise ticket for VPC team else raise ticket for IKS team.",
 	},
 	"ListSecurityGroupsFailed": {
 		Code:        "ListSecurityGroupsFailed",
 		Description: "Unable to fetch list of securityGroup.",
 		Type:        util.RetrivalFailed,
 		RC:          500,
-		Action:      "Unable to list securityGroup. Run 'ibmcloud is securityGroups' to list available securityGroups in your account.",
+		Action:      "Unable to list securityGroup. Target to appropriate region 'ibmcloud target -r <region>' and verify if 'ibmcloud is securityGroups' is returning the securityGroups. If it is not returning then raise ticket for VPC team else raise ticket for IKS team.",
 	},
 	"SecurityGroupFindFailedWithVPCAndSecurityGroupName": {
 		Code:        "SecurityGroupFindFailedWithVPCAndSecurityGroupName",
 		Description: "A securityGroup with the specified cluster securityGroup name '%s' could not be found.",
 		Type:        util.RetrivalFailed,
 		RC:          404,
-		Action:      "Verify that the securityGroup from the cluster securityGroup list exists. Run 'ibmcloud is securityGroups' to list available securityGroups in your account.",
+		Action:      "Verify that the cluster securityGroup exists. Target to appropriate region 'ibmcloud target -r <region>' and verify if 'ibmcloud is securityGroups' is returning the securityGroups. Please provide the output and raise ticket for IKS team.",
 	},
 	"ListVolumesFailed": {
 		Code:        "ListVolumesFailed",

file/provider/get_security_group.go

@@ -77,18 +77,19 @@ func (vpcs *VPCSession) getSecurityGroupByVPCAndSecurityGroupName(securityGroupR
 			startUrl, err := url.Parse(securityGroups.Next.Href)
 			if err != nil {
 				// API call is failed
-				vpcs.Logger.Error("The next parameter of the securityGroup list could not be parsed.", zap.Reflect("Next", securityGroups.Next.Href), zap.Error(err))
+				vpcs.Logger.Warn("The next parameter of the securityGroup list could not be parsed.", zap.Reflect("Next", securityGroups.Next.Href), zap.Error(err))
 				return "", userError.GetUserError(string("SecurityGroupFindFailedWithVPCAndSecurityGroupName"), err, securityGroupRequest.Name)
 			}
 
 			vpcs.Logger.Info("startUrl", zap.Reflect("startUrl", startUrl))
 			start = startUrl.Query().Get("start") //parse query param into map
 			if start == "" {
 				// API call is failed
-				vpcs.Logger.Error("The start specified in the next parameter of the securityGroup list is empty.", zap.Reflect("startUrl", startUrl))
+				vpcs.Logger.Warn("The start specified in the next parameter of the securityGroup list is empty.", zap.Reflect("startUrl", startUrl))
 				return "", userError.GetUserError(string("SecurityGroupFindFailedWithVPCAndSecurityGroupName"), errors.New("no securityGroup found"), securityGroupRequest.Name)
 			}
-
+		} else {
+			return "", userError.GetUserError(string("ListSecurityGroupsFailed"), errors.New("SecurityGroup list is empty"))
 		}
 	}
 

file/provider/get_subnet.go

@@ -78,18 +78,19 @@ func (vpcs *VPCSession) getSubnetByZoneAndSubnetID(subnetRequest provider.Subnet
 			startUrl, err := url.Parse(subnets.Next.Href)
 			if err != nil {
 				// API call is failed
-				vpcs.Logger.Error("The next parameter of the subnet list could not be parsed.", zap.Reflect("Next", subnets.Next.Href), zap.Error(err))
+				vpcs.Logger.Warn("The next parameter of the subnet list could not be parsed.", zap.Reflect("Next", subnets.Next.Href), zap.Error(err))
 				return "", userError.GetUserError(string("SubnetFindFailedWithZoneAndSubnetID"), err, subnetRequest.ZoneName, subnetRequest.SubnetIDList)
 			}
 
 			vpcs.Logger.Info("startUrl", zap.Reflect("startUrl", startUrl))
 			start = startUrl.Query().Get("start") //parse query param into map
 			if start == "" {
 				// API call is failed
-				vpcs.Logger.Error("The start specified in the next parameter of the subnet list is empty.", zap.Reflect("start", startUrl))
+				vpcs.Logger.Warn("The start specified in the next parameter of the subnet list is empty.", zap.Reflect("start", startUrl))
 				return "", userError.GetUserError(string("SubnetFindFailedWithZoneAndSubnetID"), errors.New("no subnet found"), subnetRequest.ZoneName, subnetRequest.SubnetIDList)
 			}
-
+		} else {
+			return "", userError.GetUserError(string("ListSubnetsFailed"), errors.New("Subnet list is empty"))
 		}
 	}