fix for sanity (#49)

Signed-off-by: Sameer Shaikh <[email protected]>

Author: sameshai

Makefile

@@ -1,5 +1,5 @@
 
-GOPACKAGES=$(shell go list ./... | grep -v /vendor/ | grep -v /samples | grep -v /common/registry/fakes | grep -v common/vpcclient/client/fakes | grep -v /common/vpcclient/riaas/fakes | grep -v /common/vpcclient/vpcfilevolume/fakes | grep -v /common/vpcclient/riaas/test | grep -v /common/vpcclient/models | grep -v /file/vpcconfig | grep -v /e2e)
+GOPACKAGES=$(shell go list ./... | grep -v /vendor/ | grep -v /samples | grep -v /common/registry/fakes | grep -v pkg/metadata/fake | grep -v common/vpcclient/client/fakes | grep -v /common/vpcclient/riaas/fakes | grep -v /common/vpcclient/vpcfilevolume/fakes | grep -v /common/vpcclient/riaas/test | grep -v /common/vpcclient/models | grep -v /file/vpcconfig | grep -v /e2e)
 GOFILES=$(shell find . -type f -name '*.go' -not -path "./vendor/*")
 ARCH = $(shell uname -m)
 LINT_VERSION="1.60.1"

pkg/metadata/fake/fake_node_info.go

@@ -63,10 +63,22 @@ type nodeMetadataManager struct {
 	workerID string
 }
 
+// NodeInfo ...
+//
+//go:generate counterfeiter -o fake/fake_node_info.go --fake-name FakeNodeInfo . NodeInfo
+type NodeInfo interface {
+	NewNodeMetadata(logger *zap.Logger) (NodeMetadata, error)
+}
+
+// NodeInfoManager ...
+type NodeInfoManager struct {
+	NodeName string
+}
+
 var _ NodeMetadata = &nodeMetadataManager{}
 
 // NewNodeMetadata ...
-func NewNodeMetadata(nodeName string, logger *zap.Logger) (NodeMetadata, error) {
+func (nodeManager *NodeInfoManager) NewNodeMetadata(logger *zap.Logger) (NodeMetadata, error) {
 	config, err := rest.InClusterConfig()
 	if err != nil {
 		return nil, err
@@ -77,7 +89,7 @@ func NewNodeMetadata(nodeName string, logger *zap.Logger) (NodeMetadata, error)
 		return nil, err
 	}
 
-	node, err := clientset.CoreV1().Nodes().Get(context.Background(), nodeName, metav1.GetOptions{})
+	node, err := clientset.CoreV1().Nodes().Get(context.Background(), nodeManager.NodeName, metav1.GetOptions{})
 	if err != nil {
 		return nil, err
 	}

pkg/metadata/metadata.go

@@ -28,7 +28,8 @@ func TestNewNodeMetadata(t *testing.T) {
 	// Creating test logger
 	logger, teardown := cloudprovider.GetTestLogger(t)
 	defer teardown()
-	nodeMeta, err := NewNodeMetadata("mynode", logger)
+	nodeInfo := NodeInfoManager{NodeName: "mynode"}
+	nodeMeta, err := nodeInfo.NewNodeMetadata(logger)
 
 	// Error will be there as there is no kubernetes running
 	assert.NotNil(t, err)