fix: Resolve unclosed SQLite connection warnings during tests #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpspri
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
Signed-off-by: Jonathan Springer <[email protected]>
jonpspri
force-pushed
the
sqllite-close
branch
from
9c73d82 to
ff77533
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses unclosed SQLite connection warnings during test execution by implementing proper resource cleanup throughout the test suite and application bootstrap code.
Key changes:
- Added
engine.dispose()calls in test fixtures to properly close database connection pools - Converted
bootstrap_default_roles()to use context manager pattern for automatic session cleanup - Added session-level cleanup in
pytest_sessionfinishto dispose module-level engine - Removed unused imports from test files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/mcpgateway/utils/test_pagination.py | Added engine.dispose() in db_session fixture cleanup; removed unused imports (typing.Any, typing.Dict, unittest.mock.MagicMock, sqlalchemy.orm.Session) |
| tests/unit/mcpgateway/test_display_name_uuid_features.py | Added engine.dispose() in db_session fixture cleanup to close connection pool |
| tests/conftest.py | Implemented pytest_sessionfinish hook to dispose module-level engine; removed unused asyncio import |
| mcpgateway/bootstrap_db.py | Converted bootstrap_default_roles() from manual session management to context manager pattern; added engine.dispose() in main() finally block; removed unused get_db import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/conftest.py
Outdated
| # This prevents ResourceWarning about unclosed database connections | ||
| try: | ||
| # First-Party | ||
| import mcpgateway.db as db_mod |
There was a problem hiding this comment.
Module 'mcpgateway.db' is imported with both 'import' and 'import from'.
Contributor
Author
There was a problem hiding this comment.
Correcting in next push.
Move mcpgateway.db import to module level and remove redundant local imports for consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Jonathan Springer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pytest_sessionfinishto close all SQLite connections at end of test sessionsbootstrap_default_roles()for proper session cleanupengine.dispose()calls in test fixtures that create their own engines🤖 Generated with Claude Code