Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 29, 2025

Support for PEtab v2 problems via amici.

WIP

@dweindl dweindl self-assigned this Oct 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 4.62185% with 227 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.32%. Comparing base (a4e55ef) to head (848567d).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pypesto/petab/objective_creator.py 0.00% 76 Missing ⚠️
pypesto/objective/amici/amici_calculator.py 6.81% 41 Missing ⚠️
pypesto/petab/importer.py 0.00% 40 Missing ⚠️
pypesto/objective/amici/amici.py 18.18% 27 Missing ⚠️
pypesto/petab/util.py 0.00% 7 Missing ⚠️
pypesto/visualize/observable_mapping.py 0.00% 6 Missing ⚠️
pypesto/visualize/model_fit.py 0.00% 5 Missing ⚠️
pypesto/hierarchical/semiquantitative/problem.py 0.00% 4 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 0.00% 3 Missing ⚠️
pypesto/hierarchical/ordinal/problem.py 0.00% 3 Missing ⚠️
... and 8 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (a4e55ef) and HEAD (848567d). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (a4e55ef) HEAD (848567d)
24 3
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1634       +/-   ##
============================================
- Coverage    83.62%   32.32%   -51.30%     
============================================
  Files          163      163               
  Lines        14086    14264      +178     
============================================
- Hits         11779     4611     -7168     
- Misses        2307     9653     +7346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added the enhancement New feature or request label Oct 29, 2025
@dweindl dweindl force-pushed the amici_petab_v2 branch 2 times, most recently from 4e645da to 4e6a0cd Compare October 31, 2025 13:00
@dweindl dweindl force-pushed the amici_petab_v2 branch 2 times, most recently from b3a14a3 to e02ee18 Compare November 5, 2025 10:10
Support for PEtab v2.

**WIP**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AMICI enhancement New feature or request PEtab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants