[WIP] Generalize block sparse matricize #163
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite block sparse
matricize
/unmatricize
to callmatricize
/unmatricize
blockwise, while before it called out toblockreshape
. The previous logic was too limited when the blocks themselves have more structure and we don't want to simplyreshape
them, for example for Kronecker blocks.Note that this is work in progress and will be coupled with a PR to KroneckerArrays.jl that will make use of this new design.