Skip to content

[WIP] Generalize block sparse matricize #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Jul 29, 2025

This rewrite block sparse matricize/unmatricize to call matricize/unmatricize blockwise, while before it called out to blockreshape. The previous logic was too limited when the blocks themselves have more structure and we don't want to simply reshape them, for example for Kronecker blocks.

Note that this is work in progress and will be coupled with a PR to KroneckerArrays.jl that will make use of this new design.

@mtfishman mtfishman marked this pull request as draft July 29, 2025 13:27
@mtfishman mtfishman changed the title Generalize block sparse matricize [WIP] Generalize block sparse matricize Jul 29, 2025
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.50%. Comparing base (83ed436) to head (5944fb6).

Files with missing lines Patch % Lines
...rProductsExt/BlockSparseArraysTensorProductsExt.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   75.95%   75.50%   -0.46%     
==========================================
  Files          36       36              
  Lines        2059     2078      +19     
==========================================
+ Hits         1564     1569       +5     
- Misses        495      509      +14     
Flag Coverage Δ
docs 7.61% <12.12%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant