Skip to content

Commit 8cf29e1

Browse files
author
Cristy
committed
use same metric for similarity and distortion
1 parent 1bfc536 commit 8cf29e1

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

wand/compare.c

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,6 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
269269
status;
270270

271271
MetricType
272-
distortion_metric = MeanSquaredErrorMetric,
273272
metric = UndefinedErrorMetric;
274273

275274
RectangleInfo
@@ -1159,7 +1158,6 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
11591158
reconstruct_image=GetImageFromList(image,1);
11601159
offset.x=0;
11611160
offset.y=0;
1162-
distortion_metric=metric;
11631161
if (subimage_search != MagickFalse)
11641162
{
11651163
char
@@ -1173,13 +1171,10 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
11731171
if (similarity_metric >= dissimilarity_threshold)
11741172
(void) ThrowMagickException(exception,GetMagickModule(),ImageWarning,
11751173
"ImagesTooDissimilar","`%s'",image->filename);
1176-
if ((metric != AbsoluteErrorMetric) &&
1177-
(metric != PeakSignalToNoiseRatioMetric))
1178-
distortion_metric=MeanSquaredErrorMetric;
11791174
}
11801175
if (similarity_image == (Image *) NULL)
1181-
difference_image=CompareImageChannels(image,reconstruct_image,channels,
1182-
distortion_metric,&distortion,exception);
1176+
difference_image=CompareImageChannels(image,reconstruct_image,channels,metric,
1177+
&distortion,exception);
11831178
else
11841179
{
11851180
Image
@@ -1190,8 +1185,8 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
11901185
*/
11911186
composite_image=CloneImage(image,0,0,MagickTrue,exception);
11921187
if (composite_image == (Image *) NULL)
1193-
difference_image=CompareImageChannels(image,reconstruct_image,
1194-
channels,distortion_metric,&distortion,exception);
1188+
difference_image=CompareImageChannels(image,reconstruct_image,channels,metric,
1189+
&distortion,exception);
11951190
else
11961191
{
11971192
Image
@@ -1202,8 +1197,8 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
12021197

12031198
(void) CompositeImage(composite_image,CopyCompositeOp,
12041199
reconstruct_image,offset.x,offset.y);
1205-
difference_image=CompareImageChannels(image,composite_image,channels,
1206-
distortion_metric,&distortion,exception);
1200+
difference_image=CompareImageChannels(image,composite_image,channels,metric,
1201+
&distortion,exception);
12071202
if (difference_image != (Image *) NULL)
12081203
{
12091204
difference_image->page.x=offset.x;
@@ -1220,8 +1215,8 @@ WandExport MagickBooleanType CompareImageCommand(ImageInfo *image_info,
12201215
Image
12211216
*sans_image;
12221217

1223-
sans_image=CompareImages(distort_image,reconstruct_image,
1224-
distortion_metric,&distortion,exception);
1218+
sans_image=CompareImages(distort_image,reconstruct_image,metric,
1219+
&distortion,exception);
12251220
if (sans_image != (Image *) NULL)
12261221
sans_image=DestroyImage(sans_image);
12271222
distort_image=DestroyImage(distort_image);

0 commit comments

Comments
 (0)