feat: Factorize login logic #2728
Open
+128
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirambd
reviewed
Nov 25, 2025
sirambd
requested changes
Nov 25, 2025
Member
sirambd
left a comment
sirambd
left a comment
There was a problem hiding this comment.
I haven't seen the latest file (LoginUtils)
app/src/main/java/com/infomaniak/mail/ui/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
factorize-login-logic
branch
2 times, most recently
from
2db4c48 to
a0ac118
Compare
tevincent
requested changes
Nov 27, 2025
LunarX
force-pushed
the
factorize-login-logic
branch
3 times, most recently
from
426f727 to
6fc51ea
Compare
tevincent
approved these changes
Nov 27, 2025
LunarX
force-pushed
the
factorize-login-logic
branch
from
93454da to
fec4c95
Compare
…l startActivity()
LunarX
force-pushed
the
factorize-login-logic
branch
from
fec4c95 to
9204fcc
Compare
|
This PR/issue depends on:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the now factorized login logic to avoid duplication
Depends on Infomaniak/android-core#613