Skip to content

Commit 7ed48ec

Browse files
committed
BUG: MINCImageIO should use signed char for CHAR and MI_TYPE_BYTE
`MINCImageIO::Write` should use `signed char` when the pixel component type is `IOComponentEnum::CHAR`. Both `IOComponentEnum::CHAR` and `MI_TYPE_BYTE` specify a _signed_ type, whereas the default `char` might be unsigned (for example, when using GCC compiler option `-funsigned-char`).
1 parent 0427c79 commit 7ed48ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Modules/IO/MINC/src/itkMINCImageIO.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1396,7 +1396,7 @@ MINCImageIO::Write(const void * buffer)
13961396
break;
13971397
case IOComponentEnum::CHAR:
13981398
volume_data_type = MI_TYPE_BYTE;
1399-
get_buffer_min_max<char>(buffer, buffer_length, buffer_min, buffer_max);
1399+
get_buffer_min_max<signed char>(buffer, buffer_length, buffer_min, buffer_max);
14001400
break;
14011401
case IOComponentEnum::USHORT:
14021402
volume_data_type = MI_TYPE_USHORT;

0 commit comments

Comments
 (0)