Try always using vec_sz > 1 for mininum/maximum

oleksandr-pavlyk · oleksandr-pavlyk · commit 2800f8acbb00 · 2024-10-26T22:16:35.000-05:00
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/maximum.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/maximum.hpp
@@ -205,7 +205,7 @@ sycl::event maximum_contig_impl(sycl::queue &exec_q,
                                 const std::vector<sycl::event> &depends = {})
 {
     using resTy = typename MaximumOutputType<argTy1, argTy2>::value_type;
-    constexpr auto vec_sz = VecSize_v<argTy1, argTy2, resTy>;
+    constexpr auto vec_sz = std::max(2u, VecSize_v<argTy1, argTy2, resTy>);
     constexpr unsigned int n_vecs = 1u;
 
     return elementwise_common::binary_contig_impl<
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/minimum.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/minimum.hpp
@@ -205,7 +205,7 @@ sycl::event minimum_contig_impl(sycl::queue &exec_q,
                                 const std::vector<sycl::event> &depends = {})
 {
     using resTy = typename MinimumOutputType<argTy1, argTy2>::value_type;
-    constexpr auto vec_sz = VecSize_v<argTy1, argTy2, resTy>;
+    constexpr auto vec_sz = std::max(2u, VecSize_v<argTy1, argTy2, resTy>);
     constexpr unsigned int n_vecs = 1u;
 
     return elementwise_common::binary_contig_impl<

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ sycl::event maximum_contig_impl(sycl::queue &exec_q,`
`205`	`205`	`const std::vector<sycl::event> &depends = {})`
`206`	`206`	`{`
`207`	`207`	`using resTy = typename MaximumOutputType<argTy1, argTy2>::value_type;`
`208`		`- constexpr auto vec_sz = VecSize_v<argTy1, argTy2, resTy>;`
	`208`	`+ constexpr auto vec_sz = std::max(2u, VecSize_v<argTy1, argTy2, resTy>);`
`209`	`209`	`constexpr unsigned int n_vecs = 1u;`
`210`	`210`
`211`	`211`	`return elementwise_common::binary_contig_impl<`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ sycl::event minimum_contig_impl(sycl::queue &exec_q,`
`205`	`205`	`const std::vector<sycl::event> &depends = {})`
`206`	`206`	`{`
`207`	`207`	`using resTy = typename MinimumOutputType<argTy1, argTy2>::value_type;`
`208`		`- constexpr auto vec_sz = VecSize_v<argTy1, argTy2, resTy>;`
	`208`	`+ constexpr auto vec_sz = std::max(2u, VecSize_v<argTy1, argTy2, resTy>);`
`209`	`209`	`constexpr unsigned int n_vecs = 1u;`
`210`	`210`
`211`	`211`	`return elementwise_common::binary_contig_impl<`