Skip to content

Implement dpnp.interp() #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
May 14, 2025
Merged

Implement dpnp.interp() #2417

merged 64 commits into from
May 14, 2025

Conversation

@vlad-perevezentsev
Copy link
Contributor

This PR suggests adding an implementation of dpnp.interp() with sycl_kernel including support for all function arguments.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_71 ran successfully.
Passed: 1229
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2025 •
edited
Loading

Coverage Status

coverage: 71.738% (-0.1%) from 71.864%
when pulling df36b25 on impl_of_interp
into acfc678 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy added this to the 0.18.0 release milestone Apr 14, 2025
antonwolfy
antonwolfy reviewed May 6, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed May 8, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed May 13, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed May 13, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev, LGTM with only a minor comment from me.

@vlad-perevezentsev vlad-perevezentsev merged commit ed06b34 into master May 14, 2025
52 of 65 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the impl_of_interp branch May 14, 2025 13:04
github-actions bot added a commit that referenced this pull request May 14, 2025
@github-actions
Implement dpnp.interp() (#2417)
d680241 
This PR suggests adding an implementation of `dpnp.interp()` with
sycl_kernel including support for all function arguments. ed06b34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderKalistratov AlexanderKalistratov AlexanderKalistratov left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.18.0 release

Development

Successfully merging this pull request may close these issues.

4 participants

@vlad-perevezentsev @coveralls @AlexanderKalistratov @antonwolfy