Changed the type of Tx size to Word32

Co-authored-by: Alexey Kuleshevich <[email protected]>

Author: Soupstraw

eras/allegra/impl/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.8.0.0
 
+* Changed `MaxTxSizeUTxO` to use `Word32`
 * Remove `TriesToForgeADA`
 * Change the type of `actualSize` and `PParameterMaxValue` fields in `OutputTooBigUTxO` to `Int`
 * Added `COMPLETE` pragma for `TxCert AllegraEra`

eras/allegra/impl/src/Cardano/Ledger/Allegra/Rules/Utxo.hs

@@ -60,6 +60,7 @@ import Data.Foldable (toList)
 import Data.Int (Int64)
 import qualified Data.Map.Strict as Map
 import Data.Set (Set)
+import Data.Word (Word32)
 import GHC.Generics (Generic)
 import Lens.Micro
 import NoThunks.Class (NoThunks)
@@ -72,7 +73,7 @@ data AllegraUtxoPredFailure era
   | OutsideValidityIntervalUTxO
       ValidityInterval -- transaction's validity interval
       SlotNo -- current slot
-  | MaxTxSizeUTxO (Mismatch 'RelLTEQ Integer)
+  | MaxTxSizeUTxO (Mismatch 'RelLTEQ Word32)
   | InputSetEmptyUTxO
   | FeeTooSmallUTxO (Mismatch 'RelGTEQ Coin)
   | ValueNotConservedUTxO (Mismatch 'RelEQ (Value era)) -- Consumed, then produced

eras/alonzo/impl/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.14.0.0
 
+* Changed `MaxTxSizeUTxO` to use `Word32`
 * Make `transValidityInterval` based on eras instead of protocol versions.
   * Remove `hardforkConwayTranslateUpperBoundForPlutusScripts` from `Cardano.Ledger.Alonzo.Era`.
   * Remove protocol version from arguments to `transValidityInterval`.

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Utxo.hs

@@ -108,6 +108,7 @@ import Data.Foldable as F (foldl', sequenceA_, toList)
 import qualified Data.Map.Strict as Map
 import Data.Set (Set)
 import qualified Data.Set as Set
+import Data.Word (Word32)
 import GHC.Generics (Generic)
 import Lens.Micro
 import NoThunks.Class (NoThunks)
@@ -125,7 +126,7 @@ data AlonzoUtxoPredFailure era
       ValidityInterval
       -- | current slot
       SlotNo
-  | MaxTxSizeUTxO (Mismatch 'RelLTEQ Integer)
+  | MaxTxSizeUTxO (Mismatch 'RelLTEQ Word32)
   | InputSetEmptyUTxO
   | FeeTooSmallUTxO (Mismatch 'RelGTEQ Coin)
   | ValueNotConservedUTxO (Mismatch 'RelEQ (Value era))

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Tx.hs

@@ -94,6 +94,7 @@ import Cardano.Ledger.Alonzo.TxWits (
   unRedeemersL,
   unTxDatsL,
  )
+import Cardano.Ledger.BaseTypes (integralToBounded)
 import Cardano.Ledger.Binary (
   Annotator,
   DecCBOR (..),
@@ -118,8 +119,10 @@ import Cardano.Ledger.State (EraUTxO, ScriptsProvided (..))
 import qualified Cardano.Ledger.State as Shelley
 import Cardano.Ledger.Val (Val ((<+>), (<×>)))
 import Control.DeepSeq (NFData (..))
+import Control.Monad.Trans.Fail.String (errorFail)
 import Data.Aeson (ToJSON (..))
 import qualified Data.ByteString.Lazy as LBS
+import Data.Int (Int64)
 import qualified Data.Map.Strict as Map
 import Data.Maybe (mapMaybe)
 import Data.Maybe.Strict (
@@ -130,7 +133,9 @@ import Data.Maybe.Strict (
 import Data.Set (Set)
 import qualified Data.Set as Set
 import Data.Typeable (Typeable)
+import Data.Word (Word32)
 import GHC.Generics (Generic)
+import GHC.Stack (HasCallStack)
 import Lens.Micro hiding (set)
 import NoThunks.Class (NoThunks)
 
@@ -217,10 +222,11 @@ auxDataAlonzoTxL = lens atAuxData (\tx txTxAuxData -> tx {atAuxData = txTxAuxDat
 {-# INLINEABLE auxDataAlonzoTxL #-}
 
 -- | txsize computes the length of the serialised bytes (for estimations)
-sizeAlonzoTxF :: forall era. EraTx era => SimpleGetter (AlonzoTx era) Integer
+sizeAlonzoTxF :: forall era. (HasCallStack, EraTx era) => SimpleGetter (AlonzoTx era) Word32
 sizeAlonzoTxF =
   to $
-    fromIntegral
+    errorFail
+      . integralToBounded @Int64 @Word32
       . LBS.length
       . serialize (eraProtVerLow @era)
       . toCBORForSizeComputation

eras/conway/impl/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.20.0.0
 
+* Changed `MaxTxSizeUTxO` to use `Word32`
 * Rename `transScriptPurpose` to `transPlutusPurposeV3`
 * Make `transValidityInterval` implicit to eras instead of protocol versions.
   * Implement `transValidityInterval` for Conway.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Utxo.hs

@@ -74,6 +74,7 @@ import Control.DeepSeq (NFData)
 import Control.State.Transition.Extended (Embed (..), STS (..))
 import Data.List.NonEmpty (NonEmpty)
 import Data.Set (Set)
+import Data.Word (Word32)
 import GHC.Generics (Generic)
 import GHC.Natural (Natural)
 import NoThunks.Class (InspectHeapNamed (..), NoThunks (..))
@@ -92,8 +93,7 @@ data ConwayUtxoPredFailure era
       ValidityInterval
       -- | current slot
       SlotNo
-  | MaxTxSizeUTxO
-      (Mismatch 'RelLTEQ Integer)
+  | MaxTxSizeUTxO (Mismatch 'RelLTEQ Word32)
   | InputSetEmptyUTxO
   | FeeTooSmallUTxO
       (Mismatch 'RelGTEQ Coin) -- The values are serialised in reverse order

eras/shelley/impl/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.17.0.0
 
+* Changed `MaxTxSizeUTxO` and `sizeShelleyTxF` to use `Word32`
 * Remove:
   * `ShelleyEpochPredFailure`
   * `ShelleyMirPredFailure`

eras/shelley/impl/cardano-ledger-shelley.cabal

@@ -102,6 +102,7 @@ library
     -Wunused-packages
 
   build-depends:
+    FailT,
     aeson >=2,
     base >=4.18 && <5,
     bytestring,

eras/shelley/impl/src/Cardano/Ledger/Shelley/Rules/Utxo.hs

@@ -98,6 +98,7 @@ import qualified Data.Map.Strict as Map
 import Data.MapExtras (extractKeys)
 import Data.Set (Set)
 import qualified Data.Set as Set
+import Data.Word (Word32)
 import GHC.Generics (Generic)
 import Lens.Micro
 import Lens.Micro.Extras (view)
@@ -169,7 +170,7 @@ data ShelleyUtxoPredFailure era
   | ExpiredUTxO
       (Mismatch 'RelLTEQ SlotNo)
   | MaxTxSizeUTxO
-      (Mismatch 'RelLTEQ Integer)
+      (Mismatch 'RelLTEQ Word32)
   | InputSetEmptyUTxO
   | FeeTooSmallUTxO
       (Mismatch 'RelGTEQ Coin)
@@ -578,7 +579,7 @@ validateMaxTxSizeUTxO pp tx =
         , mismatchExpected = maxTxSize
         }
   where
-    maxTxSize = toInteger (pp ^. ppMaxTxSizeL)
+    maxTxSize = pp ^. ppMaxTxSizeL
     txSize = tx ^. sizeTxF
 
 -- | This monadic action captures the final stages of the UTXO(S) rule. In particular it