Skip to content

Avoid branching on "translateUpperBoundForPlutusScripts" protocol version #5126

New issue
New issue
Closed
#5230
Closed
Avoid branching on "translateUpperBoundForPlutusScripts" protocol version#5126
#5230
Assignees
aniketd
Labels
🍰 good first issueGood for newcomers💳 technical-debtIssues related to technical debt we introduced
@lehins

Description

@lehins
lehins
opened on Jun 17, 2025

It will provide more clarity and code readability if we reimplement transValidityInterval for Conway with new translation and old translation for pre-Conway eras:

cardano-ledger/eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Plutus/TxInfo.hs

Lines 228 to 239 in b7f6382

transValidityInterval _ protVer epochInfo systemStart = \case
ValidityInterval SNothing SNothing -> pure PV1.always
ValidityInterval (SJust i) SNothing -> PV1.from <$> transSlotToPOSIXTime i
ValidityInterval SNothing (SJust i) -> do
t <- transSlotToPOSIXTime i
pure $
if HardForks.translateUpperBoundForPlutusScripts protVer
then
PV1.Interval
(PV1.LowerBound PV1.NegInf True)
(PV1.strictUpperBound t)
else PV1.to t

This would effectively remove the need for standalone translateUpperBoundForPlutusScripts function

Metadata

Metadata

Assignees

Labels

🍰 good first issueGood for newcomers💳 technical-debtIssues related to technical debt we introduced

Type

No type

Projects

Ledger Tech Debt

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions