Run Imp conformance tests at the epoch boundary #5221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
3 times, most recently
from
4f1f7f3 to
5e3b8f3
Compare
Contributor
Author
|
Lots of tests are failing due to IntersectMBO/formal-ledger-specifications#856 |
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
4 times, most recently
from
a4e23aa to
b0f45e8
Compare
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
2 times, most recently
from
7f38332 to
5a95635
Compare
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
2 times, most recently
from
7c350c5 to
3913110
Compare
teodanciu
reviewed
Aug 18, 2025
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
A few questions from the confused
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/Imp.hs
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
3 times, most recently
from
48acc4a to
06ae7e7
Compare
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
4 times, most recently
from
e3a6c97 to
a75a07e
Compare
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
2 times, most recently
from
294dff9 to
db24f14
Compare
Also update the pulser when modifying the protocol version in Conway Co-authored-by: teodanciu <[email protected]>
Soupstraw
force-pushed
the
jj/imp-conformance-epoch-boundary
branch
from
db24f14 to
a80dc14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the machinery to run conformance tests whenever an ImpTest crosses the epoch boundary. I could not yet enable this hook, because the snapshot computation is buggy in the spec and that causes the conformance test to fail in most test cases.
This is a revival of #4762
close #4751
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).