Skip to content

Commit 3104cc8

Browse files
committed
Make Dijkstra genesis parsing dependent on ExperimentalHardForksEnabled
1 parent 86c8beb commit 3104cc8

File tree

4 files changed

+20
-16
lines changed

4 files changed

+20
-16
lines changed

cardano-node/src/Cardano/Node/Configuration/POM.hs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -325,15 +325,16 @@ instance FromJSON PartialNodeConfiguration where
325325
protocol <- v .:? "Protocol" .!= CardanoProtocol
326326
pncProtocolConfig <-
327327
case protocol of
328-
CardanoProtocol ->
328+
CardanoProtocol -> do
329+
hfp <- parseHardForkProtocol v
329330
fmap (Last . Just) $
330331
NodeProtocolConfigurationCardano
331332
<$> parseByronProtocol v
332333
<*> parseShelleyProtocol v
333334
<*> parseAlonzoProtocol v
334335
<*> parseConwayProtocol v
335-
<*> parseDijkstraProtocol v
336-
<*> parseHardForkProtocol v
336+
<*> (if npcExperimentalHardForksEnabled hfp then Just <$> parseDijkstraProtocol v else pure Nothing)
337+
<*> pure hfp
337338
<*> parseCheckpoints v
338339
pncMaybeMempoolCapacityOverride <- Last <$> parseMempoolCapacityBytesOverride v
339340

@@ -585,8 +586,9 @@ instance FromJSON PartialNodeConfiguration where
585586
npcTestConwayHardForkAtEpoch <- v .:? "TestConwayHardForkAtEpoch"
586587
npcTestConwayHardForkAtVersion <- v .:? "TestConwayHardForkAtVersion"
587588

588-
npcTestDijkstraHardForkAtEpoch <- v .:? "TestDijkstraHardForkAtEpoch"
589-
npcTestDijkstraHardForkAtVersion <- v .:? "TestDijkstraHardForkAtVersion"
589+
(npcTestDijkstraHardForkAtEpoch, npcTestDijkstraHardForkAtVersion) <- if npcExperimentalHardForksEnabled
590+
then (,) <$> v .:? "TestConwayHardForkAtEpoch" <*> v .:? "TestConwayHardForkAtVersion"
591+
else pure (Nothing, Nothing)
590592

591593
pure NodeHardForkProtocolConfiguration
592594
{ npcExperimentalHardForksEnabled

cardano-node/src/Cardano/Node/Protocol/Cardano.hs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ mkSomeConsensusProtocolCardano
6161
-> NodeShelleyProtocolConfiguration
6262
-> NodeAlonzoProtocolConfiguration
6363
-> NodeConwayProtocolConfiguration
64-
-> NodeDijkstraProtocolConfiguration
64+
-> Maybe NodeDijkstraProtocolConfiguration
6565
-> NodeHardForkProtocolConfiguration
6666
-> NodeCheckpointsConfiguration
6767
-> Maybe ProtocolFilepaths
@@ -87,10 +87,7 @@ mkSomeConsensusProtocolCardano NodeByronProtocolConfiguration {
8787
npcConwayGenesisFile,
8888
npcConwayGenesisFileHash
8989
}
90-
NodeDijkstraProtocolConfiguration {
91-
npcDijkstraGenesisFile,
92-
npcDijkstraGenesisFileHash
93-
}
90+
ndpc
9491
NodeHardForkProtocolConfiguration {
9592
-- During testing of the Alonzo era, we conditionally declared that we
9693
-- knew about the Alonzo era. We do so only when a config option for
@@ -132,10 +129,14 @@ mkSomeConsensusProtocolCardano NodeByronProtocolConfiguration {
132129
Conway.readGenesis npcConwayGenesisFile
133130
npcConwayGenesisFileHash
134131

135-
(dijkstraGenesis, _dijkstraGenesisHash) <-
136-
firstExceptT CardanoProtocolInstantiationDijkstraGenesisReadError $
137-
Dijkstra.readGenesis npcDijkstraGenesisFile
138-
npcDijkstraGenesisFileHash
132+
dijkstraGenesis <-
133+
case ndpc of
134+
Nothing -> pure Dijkstra.emptyDijkstraGenesis
135+
Just (NodeDijkstraProtocolConfiguration npcDijkstraGenesisFile npcDijkstraGenesisFileHash) -> do
136+
(dijkstraGenesis, _dijkstraGenesisHash) <- firstExceptT CardanoProtocolInstantiationDijkstraGenesisReadError $
137+
Dijkstra.readGenesis npcDijkstraGenesisFile
138+
npcDijkstraGenesisFileHash
139+
pure dijkstraGenesis
139140

140141
shelleyLeaderCredentials <-
141142
firstExceptT CardanoProtocolInstantiationPraosLeaderCredentialsError $

cardano-node/src/Cardano/Node/Protocol/Dijkstra.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
module Cardano.Node.Protocol.Dijkstra
77
( readGenesis
88
, readGenesisMaybe
9+
, emptyDijkstraGenesis
910
) where
1011

1112
import Cardano.Api

cardano-node/src/Cardano/Node/Types.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ data NodeProtocolConfiguration =
208208
NodeShelleyProtocolConfiguration
209209
NodeAlonzoProtocolConfiguration
210210
NodeConwayProtocolConfiguration
211-
NodeDijkstraProtocolConfiguration
211+
(Maybe NodeDijkstraProtocolConfiguration)
212212
NodeHardForkProtocolConfiguration
213213
NodeCheckpointsConfiguration
214214
deriving (Eq, Show)
@@ -443,7 +443,7 @@ instance AdjustFilePaths NodeProtocolConfiguration where
443443
(adjustFilePaths f pcs)
444444
(adjustFilePaths f pca)
445445
(adjustFilePaths f pcc)
446-
(adjustFilePaths f pcd)
446+
(adjustFilePaths f <$> pcd)
447447
pch
448448
(adjustFilePaths f pccp)
449449

0 commit comments

Comments
 (0)