-
Notifications
You must be signed in to change notification settings - Fork 1
Milestone
Description
We are currently logging warnings when GraalVM is not present on the system.
But since we're dropping the requirement for GraalVM, log mesages should be removed.
The goal of this task is to adjust logging and see if there are any other places in the codebase requiring such adjustments.
See code here:
Lines 186 to 204 in 0b268ab
| private void initialEngineCheckup() { | |
| // check VM | |
| if (!Version.getCurrent().isRelease()) { | |
| String specVersion = System.getProperty("java.specification.version", UNKNOWN_SYS_PROP); | |
| String vendorVersion = System.getProperty("java.vendor.version", specVersion); | |
| String vendor = System.getProperty("java.vendor", UNKNOWN_SYS_PROP); | |
| logger.warn("Javascript Modules Engine requires GraalVM for production usage, detected {} (vendor: {}).", | |
| vendorVersion, vendor); | |
| return; | |
| } | |
| // Check if the 'js' extension is installed | |
| try (Context context = Context.create()) { | |
| if (!context.getEngine().getLanguages().containsKey(JS)) { | |
| logger.error( | |
| "Javascript Modules Engine detected GraalVM, but the 'js' extension is not installed. You can install it by running: gu install js"); | |
| } | |
| } | |
| } |
Please also check the error about the "js" extension (lines 198-204), I don't know if when using OpenJDK the key is the same.
Metadata
Metadata
Assignees
Labels
No labels