[FIR] Don't report EXTENSION_SHADOWED_BY_MEMBER on overrides

#KT-79430 Fixed

Author: cypressious

compiler/fir/analysis-tests/testData/resolve/diagnostics/methodOfAnyImplementedInInterface.kt

@@ -34,12 +34,12 @@ interface I {
 }
 
 interface J : I {
-    override fun String.<!EXTENSION_SHADOWED_BY_MEMBER!>hashCode<!>(): Int = 1
+    override fun String.hashCode(): Int = 1
 
     context(string: String)
     override fun hashCode(): Int = 1
 
-    override fun String.<!EXTENSION_SHADOWED_BY_MEMBER!>toString<!>(): String = ""
+    override fun String.toString(): String = ""
 
     context(string: String)
     override fun toString(): String = ""

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirExtensionShadowedByMemberChecker.kt

@@ -47,7 +47,8 @@ sealed class FirExtensionShadowedByMemberChecker(kind: MppCheckerKind) : FirCall
             declaration.receiverParameter.let { it == null || it.typeRef.coneType.canBeNull(context.session) } ||
             declaration.nameOrSpecialName == NO_NAME_PROVIDED ||
             // A common pattern, KT-70012
-            declaration.isActual
+            declaration.isActual ||
+            declaration.isOverride
         ) {
             return
         }

compiler/testData/diagnostics/tests/declarationChecks/localDeclarationModifiers.fir.kt

@@ -0,0 +1,16 @@
+// RUN_PIPELINE_TILL: FRONTEND
+package d
+
+class T {
+    fun baz() = 1
+}
+
+fun foo() {
+    <!WRONG_MODIFIER_TARGET!>public<!> val i = 11
+    <!WRONG_MODIFIER_TARGET!>abstract<!> val <!VARIABLE_WITH_NO_TYPE_NO_INITIALIZER!>j<!>
+    <!WRONG_MODIFIER_TARGET!>override<!> fun T.baz() = 2
+    <!WRONG_MODIFIER_TARGET!>private<!> fun bar() = 2
+}
+
+/* GENERATED_FIR_TAGS: classDeclaration, funWithExtensionReceiver, functionDeclaration, integerLiteral, localFunction,
+localProperty, override, propertyDeclaration */

compiler/testData/diagnostics/tests/declarationChecks/localDeclarationModifiers.kt

@@ -1,5 +1,4 @@
 // RUN_PIPELINE_TILL: FRONTEND
-// FIR_IDENTICAL
 package d
 
 class T {

compiler/testData/diagnostics/tests/declarationChecks/localFunctionNoInheritVisibility.fir.kt

@@ -0,0 +1,20 @@
+// RUN_PIPELINE_TILL: FRONTEND
+package d
+
+class T {
+    fun baz() = 1
+}
+
+<!WRONG_MODIFIER_TARGET!>override<!> fun zzz() {}
+
+fun foo(t: T) {
+    <!WRONG_MODIFIER_TARGET!>override<!> fun T.baz() = 2
+
+    // was "Visibility is unknown yet exception"
+    t.baz()
+
+    zzz()
+}
+
+/* GENERATED_FIR_TAGS: classDeclaration, funWithExtensionReceiver, functionDeclaration, integerLiteral, localFunction,
+override */

compiler/testData/diagnostics/tests/declarationChecks/localFunctionNoInheritVisibility.kt

@@ -1,5 +1,4 @@
 // RUN_PIPELINE_TILL: FRONTEND
-// FIR_IDENTICAL
 package d
 
 class T {

compiler/testData/diagnostics/tests/extensionShadowedByMemberOverride.fir.kt

@@ -0,0 +1,16 @@
+// RUN_PIPELINE_TILL: BACKEND
+// ISSUE: KT-79430
+class Foo {
+    fun bar() {}
+}
+
+interface Extension<T> {
+    fun T.bar()
+}
+
+class FooExtension : Extension<Foo> {
+    override fun Foo.bar() {}
+}
+
+/* GENERATED_FIR_TAGS: classDeclaration, funWithExtensionReceiver, functionDeclaration, interfaceDeclaration,
+nullableType, override, typeParameter */

compiler/testData/diagnostics/tests/extensionShadowedByMemberOverride.kt

@@ -1,5 +1,4 @@
 // RUN_PIPELINE_TILL: BACKEND
-// FIR_IDENTICAL
 // ISSUE: KT-79430
 class Foo {
     fun bar() {}