Skip to content

Commit d81d740

Browse files
committed
Add empty logger to tests
1 parent 82b5df6 commit d81d740

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

shared/src/commonTest/kotlin/org/jetbrains/kotlinconf/storage/MultiplatformSettingsStorageMigrationTest.kt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ import com.russhwolf.settings.observable.makeObservable
77
import com.russhwolf.settings.set
88
import kotlinx.coroutines.flow.first
99
import kotlinx.coroutines.test.runTest
10-
import kotlinx.serialization.json.Json
11-
import org.jetbrains.kotlinconf.NotificationSettings
10+
import org.jetbrains.kotlinconf.utils.Logger
1211
import kotlin.test.Test
1312
import kotlin.test.assertEquals
1413
import kotlin.test.assertNull
@@ -19,6 +18,10 @@ class MultiplatformSettingsStorageMigrationTest {
1918
@OptIn(ExperimentalSettingsApi::class)
2019
private fun inMemorySettings(): ObservableSettings = MapSettings().makeObservable()
2120

21+
private fun emptyLogger() = object : Logger {
22+
override fun log(tag: String, lazyMessage: () -> String) {}
23+
}
24+
2225
/**
2326
* Creates a storage object with data matching the older, 2025 storage version.
2427
*/
@@ -38,7 +41,7 @@ class MultiplatformSettingsStorageMigrationTest {
3841
@Test
3942
fun migration_2025_to_2026_updates_version() {
4043
val settings = get2025Settings()
41-
val storage = MultiplatformSettingsStorage(settings)
44+
val storage = MultiplatformSettingsStorage(settings, emptyLogger())
4245

4346
// Run migrations
4447
storage.ensureCurrentVersion()
@@ -50,7 +53,7 @@ class MultiplatformSettingsStorageMigrationTest {
5053
@Test
5154
fun migration_2026_to_2026_removes_news_cache() {
5255
val settings = get2025Settings()
53-
val storage = MultiplatformSettingsStorage(settings)
56+
val storage = MultiplatformSettingsStorage(settings, emptyLogger())
5457

5558
// Run migrations
5659
storage.ensureCurrentVersion()
@@ -62,7 +65,7 @@ class MultiplatformSettingsStorageMigrationTest {
6265
@Test
6366
fun migration_2026_to_2026_migrates_notification_settings() = runTest {
6467
val settings = get2025Settings()
65-
val storage = MultiplatformSettingsStorage(settings)
68+
val storage = MultiplatformSettingsStorage(settings, emptyLogger())
6669

6770
// Run migrations
6871
storage.ensureCurrentVersion()
@@ -78,7 +81,7 @@ class MultiplatformSettingsStorageMigrationTest {
7881
settings["userId2025"] = "user-123"
7982
settings["newsCache"] = "legacy-data"
8083
settings["notificationSettings"] = "{\"sessionReminders\":false,\"scheduleUpdates\":true}"
81-
val storage = MultiplatformSettingsStorage(settings)
84+
val storage = MultiplatformSettingsStorage(settings, emptyLogger())
8285

8386
// Run migrations
8487
storage.ensureCurrentVersion()
@@ -93,7 +96,7 @@ class MultiplatformSettingsStorageMigrationTest {
9396
val settings = inMemorySettings()
9497
settings["storageVersion"] = 2024_000 // A version we don't have a migration for
9598
settings["favorites"] = "[\"S1\",\"S2\"]"
96-
val storage = MultiplatformSettingsStorage(settings)
99+
val storage = MultiplatformSettingsStorage(settings, emptyLogger())
97100

98101
// Run migrations
99102
storage.ensureCurrentVersion()

0 commit comments

Comments
 (0)