Merge pull request #74 from huanglangwen/oop

Fix issue of inconsistent size

Author: ChrisRackauckas

src/differentiation/compute_jacobian_ad.jl

@@ -120,7 +120,8 @@ function forwarddiff_color_jacobian(f,x::AbstractArray{<:Number},jac_cache::Forw
             for j in 1:chunksize
                 col_index = (i-1)*chunksize + j
                 (col_index > ncols) && return J
-                J = J + mapreduce(i -> i==col_index ? partials.(vec(fx), j) : zeros(nrows), hcat, 1:ncols)
+                Ji = mapreduce(i -> i==col_index ? partials.(vec(fx), j) : zeros(nrows), hcat, 1:ncols)
+                J = J + (size(Ji)!=size(J) ? reshape(Ji,size(J)) : Ji) #branch when size(dx) == (1,) => size(Ji) == (1,) while size(J) == (1,1)
             end
         end
     end

test/test_ad.jl

@@ -218,4 +218,10 @@ J = forwarddiff_color_jacobian(oopf,x)
 @test J ≈ Matrix(I,4,4)
 J = zero(J)
 forwarddiff_color_jacobian!(J,iipf,x,dx=similar(x))
-@test J ≈ Matrix(I,4,4)
+@test J ≈ Matrix(I,4,4)
+
+#1x1 SVector test
+x = SVector{1}([1.])
+f(x) = x
+J = forwarddiff_color_jacobian(f,x)
+@test J ≈ SMatrix{1,1}([1.])