1.8 compatibility: fix cholesky nopivot argument. (#390)

Author: maleadt

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        version: ['1.6', '^1.7.0-beta2', 'nightly']
+        version: ['1.6', '^1.7', 'nightly']
         os: [ubuntu-latest, macOS-latest, windows-latest]
         arch: [x64]
     steps:

src/host/linalg.jl

@@ -101,21 +101,32 @@ end
 
 Base.copy(D::Diagonal{T, <:AbstractGPUArray{T, N}}) where {T, N} = Diagonal(copy(D.diag))
 
-# prevent scalar indexing
-function LinearAlgebra.cholesky!(D::Diagonal{T, <:AbstractGPUArray{T, N}}, 
-    ::Val{false} = Val(false); check::Bool = true
-) where {T, N}
-    info = 0
-    if mapreduce(x -> isreal(x) && isposdef(x), &, D.diag)
-        D.diag .= sqrt.(D.diag)
-    else
-        info = findfirst(x -> !isreal(x) || !isposdef(x), collect(D.diag))
-        check && throw(PosDefException(info))
+if VERSION <= v"1.8-"
+    function LinearAlgebra.cholesky!(D::Diagonal{<:Any, <:AbstractGPUArray},
+                                     ::Val{false} = Val(false); check::Bool = true)
+        info = 0
+        if mapreduce(x -> isreal(x) && isposdef(x), &, D.diag)
+            D.diag .= sqrt.(D.diag)
+        else
+            info = findfirst(x -> !isreal(x) || !isposdef(x), collect(D.diag))
+            check && throw(PosDefException(info))
+        end
+        Cholesky(D, 'U', convert(LinearAlgebra.BlasInt, info))
+    end
+else
+    function LinearAlgebra.cholesky!(D::Diagonal{<:Any, <:AbstractGPUArray},
+                                    ::NoPivot = NoPivot(); check::Bool = true)
+        info = 0
+        if mapreduce(x -> isreal(x) && isposdef(x), &, D.diag)
+            D.diag .= sqrt.(D.diag)
+        else
+            info = findfirst(x -> !isreal(x) || !isposdef(x), collect(D.diag))
+            check && throw(PosDefException(info))
+        end
+        Cholesky(D, 'U', convert(LinearAlgebra.BlasInt, info))
     end
-    Cholesky(D, 'U', convert(LinearAlgebra.BlasInt, info))
 end
 
-
 ## matrix multiplication
 
 function generic_matmatmul!(C::AbstractArray{R}, A::AbstractArray{T}, B::AbstractArray{S}, a::Number, b::Number) where {T,S,R}