-
-
Notifications
You must be signed in to change notification settings - Fork 285
More registry status #4300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More registry status #4300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the registry status command by tracking when registries are added or updated and printing richer diagnostics.
- Persist registry update timestamps during registry download/install
- Improve
statusoutput with registry format, last-updated times, and package-server info - Introduce
get_registry_typehelper for classifying registry layouts
Comments suppressed due to low confidence (2)
src/Registry/Registry.jl:628
- [nitpick] Public helper functions like
get_registry_typeshould include a short docstring explaining the classification rules and return values to aid future maintainers.
function get_registry_type(reg)
src/Registry/Registry.jl:585
- The new status-printing logic and update-log handling lack automated tests. Consider adding unit tests for
download_registriesto verify correct timestamp storage and forstatusto validate the enhanced output formatting.
registry_update_log = get_registry_update_log()
739fe60 to
5e91a6e
Compare
790fd9d to
4af6d26
Compare
|
One way to test would be to run a registry status call, collect the ouput and see that it looks reasonable? |
|
Seems like the test might be flaky? |
|
I haven't investigated why it happens yet but I can reproduce it locally. |
|
The reason is a not at all obvious interaction between I could add an update of update log in the symlinking and copying code paths, but it feels somewhat questionable since there's not generally a way for Pkg to update copied registries. On the other hand those installation options are probably almost only used in the tests, so little reason to worry about the update info being misleading. |
Extend the registry status command to show more information that can be useful for troubleshooting.
Example:
Feel free to bikeshed the layout and suggest more information that is useful and can easily be added.
The first commit updates the update log when a registry is first added. Without this the "last updated" information can be wildly wrong if a registry is removed at some point and much later added again.
I haven't looked into how this can be tested yet.It has some rudimentary testing now at least.