Skip to content

Commit 5d69576

Browse files
authored
Support DualLayout (#85)
1 parent de57bfe commit 5d69576

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "BlockBandedMatrices"
22
uuid = "ffab5731-97b5-5995-9138-79e8c1846df0"
3-
version = "0.9.1"
3+
version = "0.9.2"
44

55
[deps]
66
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/BandedBlockBandedMatrix.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,8 @@ end
256256
################################
257257

258258
bandedblockbandedcolumns(L::AbstractColumnMajor) = BandedBlockBandedColumnMajor()
259+
bandedblockbandedcolumns(L::AbstractRowMajor) = BandedBlockBandedColumns{RowMajor}()
260+
bandedblockbandedcolumns(::DualLayout{ML}) where ML = bandedblockbandedcolumns(ML())
259261
bandedblockbandedcolumns(_) = BandedBlockBandedColumns{UnknownLayout}()
260262

261263
MemoryLayout(::Type{<:BandedBlockBandedMatrix{<:Any,BLOCKS}}) where BLOCKS =

test/test_bandedblockbanded.jl

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using BlockArrays, BandedMatrices, BlockBandedMatrices, FillArrays, SparseArrays, Test, ArrayLayouts , LinearAlgebra
2-
import BlockBandedMatrices: _BandedBlockBandedMatrix, blockcolsupport, blockrowsupport, colsupport, rowsupport, isbandedblockbanded, bandeddata
2+
import BlockBandedMatrices: _BandedBlockBandedMatrix, blockcolsupport, blockrowsupport, colsupport, rowsupport,
3+
isbandedblockbanded, bandeddata, BandedBlockBandedColumns
34

45
@testset "BandedBlockBandedMatrix" begin
56
@testset "constructors" begin
@@ -481,6 +482,11 @@ import BlockBandedMatrices: _BandedBlockBandedMatrix, blockcolsupport, blockrows
481482
@test subblockbandwidths(B) == (1,1)
482483
@test blockbandwidths(B) == (0,0)
483484
end
485+
486+
@testset "DualLayout blocks" begin
487+
A = _BandedBlockBandedMatrix(PseudoBlockVector([1,2,3],[1,2])', blockedrange([1,2]), (-1,1), (-1,1))
488+
@test MemoryLayout(A) isa BandedBlockBandedColumns{RowMajor}
489+
end
484490
end
485491

486492
if false # turned off since tests have check-bounds=yes

0 commit comments

Comments
 (0)