Add copy for BandedBlockBandedMatrix (#102)

* Add copy for BandedBlockBandedMatrix

* add converts

* Update test_bandedblockbanded.jl

* turn of doc test

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockBandedMatrices"
 uuid = "ffab5731-97b5-5995-9138-79e8c1846df0"
-version = "0.10.0"
+version = "0.10.1"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

docs/make.jl

@@ -3,7 +3,7 @@ using Documenter, BlockBandedMatrices
 makedocs(
     modules = [BlockBandedMatrices],
     sitename = "BlockBandedMatrices.jl",
-    strict = VERSION.major == 1 && sizeof(Int) == 8, # only strict mode on 1.0 and Int64
+    strict = false, # VERSION.major == 1 && sizeof(Int) == 8, # only strict mode on 1.0 and Int64
     pages = Any[
         "Home" => "index.md"
     ]

src/BandedBlockBandedMatrix.jl

@@ -220,6 +220,15 @@ BandedBlockBandedMatrix(A::AbstractMatrix{T}) where T = BandedBlockBandedMatrix{
 BandedBlockBandedMatrix(A::AbstractMatrix, rdims::AbstractVector{Int}, cdims::AbstractVector{Int}, lu::NTuple{2,Int}, λμ::NTuple{2,Int}) =
     BandedBlockBandedMatrix(A, (blockedrange(rdims), blockedrange(cdims)), lu, λμ)
 
+copy(B::BandedBlockBandedMatrix) = _BandedBlockBandedMatrix(copy(B.data), B.raxis, blockbandwidths(B), subblockbandwidths(B))
+AbstractArray{T}(B::BandedBlockBandedMatrix) where T = _BandedBlockBandedMatrix(AbstractArray{T}(B.data), B.raxis, blockbandwidths(B), subblockbandwidths(B))
+AbstractMatrix{T}(B::BandedBlockBandedMatrix) where T = _BandedBlockBandedMatrix(AbstractMatrix{T}(B.data), B.raxis, blockbandwidths(B), subblockbandwidths(B))
+convert(::Type{AbstractArray{T}}, B::BandedBlockBandedMatrix) where T = _BandedBlockBandedMatrix(convert(AbstractArray{T},B.data), B.raxis, blockbandwidths(B), subblockbandwidths(B))
+convert(::Type{AbstractMatrix{T}}, B::BandedBlockBandedMatrix) where T = _BandedBlockBandedMatrix(convert(AbstractMatrix{T},B.data), B.raxis, blockbandwidths(B), subblockbandwidths(B))
+convert(::Type{AbstractArray{T}}, B::BandedBlockBandedMatrix{T}) where T = B
+convert(::Type{AbstractMatrix{T}}, B::BandedBlockBandedMatrix{T}) where T = B
+
+
 similar(A::BandedBlockBandedMatrix, ::Type{T}, axes::NTuple{2,AbstractUnitRange{Int}}) where T =
     BandedBlockBandedMatrix{T}(undef, axes, blockbandwidths(A), subblockbandwidths(A))
 

src/BlockBandedMatrices.jl

@@ -7,7 +7,7 @@ import Base: getindex, setindex!, checkbounds, @propagate_inbounds, convert,
                         unsafe_convert, fill!, length, first, last,
                         eltype, getindex, to_indices, to_index,
                         reindex, _maybetail, tail, @_propagate_inbounds_meta,
-                        ==, axes, copyto!, similar, OneTo
+                        ==, axes, copy, copyto!, similar, OneTo
 
 import Base.Broadcast: BroadcastStyle, AbstractArrayStyle, DefaultArrayStyle, Broadcasted, broadcasted,
                         materialize, materialize!

test/test_bandedblockbanded.jl

@@ -1,5 +1,5 @@
 using BlockArrays, BandedMatrices, BlockBandedMatrices, FillArrays, SparseArrays, Test, ArrayLayouts , LinearAlgebra
-import BlockBandedMatrices: _BandedBlockBandedMatrix, blockcolsupport, blockrowsupport, colsupport, rowsupport, 
+import BlockBandedMatrices: _BandedBlockBandedMatrix, blockcolsupport, blockrowsupport, colsupport, rowsupport,
                             isbandedblockbanded, bandeddata, BandedBlockBandedColumns
 import ArrayLayouts: RangeCumsum
 
@@ -300,7 +300,7 @@ import ArrayLayouts: RangeCumsum
         @test B isa BandedBlockBandedMatrix
         @test blockbandwidths(V) == blockbandwidths(B) == (2,0)
         @test subblockbandwidths(V) == subblockbandwidths(B) == subblockbandwidths(A) == (λ,μ)
-        @test B == V == A[Block.(2:3), Block.(3:4)] 
+        @test B == V == A[Block.(2:3), Block.(3:4)]
 
         @test A[Block.(2:3), Block.(3:4)] isa BandedBlockBandedMatrix
 
@@ -504,6 +504,18 @@ import ArrayLayouts: RangeCumsum
         A = _BandedBlockBandedMatrix(data, rows,cols, (l,u), (λ,μ))
         @test A == BandedBlockBandedMatrix(A, (2,1), (2,1)) == BandedBlockBandedMatrix{Float64}(A, (2,1), (2,1))
     end
+
+    @testset "convert" begin
+        l , u = 1,1
+        λ , μ = 1,1
+        N = M = 4
+        cols = rows = 1:N
+        data = reshape(collect(1:(λ+μ+1)*(l+u+1)*sum(cols)), ((λ+μ+1)*(l+u+1), sum(cols)))
+        A = _BandedBlockBandedMatrix(data, rows,cols, (l,u), (λ,μ))
+        @test AbstractArray{Float64}(A) == AbstractMatrix{Float64}(A) == AbstractArray{Int}(A) == AbstractMatrix{Int}(A) == copy(A) == A
+        @test convert(AbstractArray{Float64}, A) == convert(AbstractMatrix{Float64}, A) == A
+        @test convert(AbstractArray{Int}, A) ≡ convert(AbstractMatrix{Int}, A) ≡ A
+    end
 end
 
 if false # turned off since tests have check-bounds=yes