new constructorof; rework plot recipe (#376)

* new constructor; rework plot recipe

* make test support v1

Author: jverzani

Project.toml

@@ -2,7 +2,7 @@ name = "Polynomials"
 uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
 license = "MIT"
 author = "JuliaMath"
-version = "2.0.20"
+version = "2.0.21"
 
 [deps]
 Intervals = "d8418881-c3e1-53bb-8760-2df7ec849ed5"

src/contrib.jl

@@ -127,6 +127,9 @@ end
 ## trick from [ConstructionBase.jl](https://github.com/JuliaObjects/ConstructionBase.jl/blob/b5686b755bd3bee29b181b3cb18fe2effa0f10a2/src/ConstructionBase.jl#L25)
 ## as noted in https://discourse.julialang.org/t/get-new-type-with-different-parameter/37253/4
 ##
-@generated function constructorof(::Type{T}) where T
-    getfield(parentmodule(T), nameof(T))
-end
+#@generated function constructorof(::Type{T}) where T
+#    getfield(parentmodule(T), nameof(T))
+#end
+
+# https://discourse.julialang.org/t/how-do-a-i-get-a-type-stripped-of-parameters/73465/11
+constructorof(::Type{T}) where T = Base.typename(T).wrapper

src/plots.jl

@@ -32,9 +32,15 @@ end
 
 poly_label(p::AbstractPolynomial) = sprint(printpoly, p)
 
-@recipe function f(p::AbstractPolynomial, x = poly_interval(p))
+#@recipe function f(p::AbstractPolynomial, x = poly_interval(p))
+#    label --> poly_label(p)
+#    x, p.(x)
+#end
+
+@recipe function f(p::AbstractPolynomial)
     label --> poly_label(p)
-    x, p.(x)
+    xlims --> extrema(poly_interval(p))
+    x -> p(x)
 end
 
 @recipe function f(p::AbstractPolynomial, a, b)

test/StandardBasis.jl

@@ -1376,21 +1376,18 @@ end
 
 @testset "Plotting" begin
     p = fromroots([-1, 1]) # x^2 - 1
-    r = -1.4:0.055999999999999994:1.4
     rec = apply_recipe(Dict{Symbol,Any}(), p)
-    @test getfield(rec[1], 1) == Dict{Symbol,Any}(:label => "-1 + x^2")
-    @test rec[1].args == (r, p.(r))
+    @test rec[1].plotattributes[:label] == "-1 + x^2"
+    @test rec[1].plotattributes[:xlims] == (-1.4, 1.4)
+
 
-    r = -1:0.02:1
     rec = apply_recipe(Dict{Symbol,Any}(), p, -1, 1)
-    @test getfield(rec[1], 1) == Dict{Symbol,Any}(:label => "-1 + x^2")
-    @test rec[1].args == (r, p.(r))
+    @test rec[1].plotattributes[:label] == "-1 + x^2"
 
     p = ChebyshevT([1,1,1])
     rec = apply_recipe(Dict{Symbol,Any}(), p)
-    r = -1.0:0.02:1.0  # uses domain(p)
-    @test rec[1].args == (r, p.(r))
-
+    @test match(r"T_0", rec[1].plotattributes[:label]) !== nothing
+    @test rec[1].plotattributes[:xlims] == (-1.0, 1.0) # uses domain(p)
 end
 
 @testset "Promotion"  begin
@@ -1458,7 +1455,7 @@ end
     end
 end
 
-using MutableArithmetics
+import MutableArithmetics
 const MA = MutableArithmetics
 
 function alloc_test(f, n)