Merge pull request #73 from JuliaReinforcementLearning/jeremiahpslewis-patch-1

Add manual trigger to CI and fix boundserrors related to CircularArrayBuffers.jl

Author: jeremiahpslewis

.devcontainer/Dockerfile

@@ -0,0 +1,3 @@
+FROM julia:1.10
+
+RUN apt-get update && apt-get install -y git

.devcontainer/devcontainer.json

@@ -0,0 +1,15 @@
+{
+  "customizations": {
+      "vscode": {
+          "extensions": [
+            "julialang.language-julia",
+            "ms-azuretools.vscode-docker"
+          ]
+      }
+  },
+  "runArgs": [
+      "--privileged"
+  ],
+  "dockerFile": "Dockerfile",
+  "updateContentCommand": "julia -e 'using Pkg; Pkg.develop(path=\".\");'"
+}

.github/workflows/CI.yml

@@ -5,6 +5,7 @@ on:
       - main
     tags: '*'
   pull_request:
+  workflow_dispatch:
 concurrency:
   # Skip intermediate builds: always.
   # Cancel intermediate builds: only if it is a pull request build.

test/episodes.jl

@@ -116,7 +116,8 @@ using Test
         @test eb.sampleable_inds == [1,1,1,1,1,0,0]
         @test eb[:action][6] == 6
         @test eb[:next_action][5] == 6
-        @test eb[6][:reward] == 0 #6 is not a valid index, the reward there is dummy, filled as zero
+        @test eb[:reward][6] == 0 #6 is not a valid index, the reward there is dummy, filled as zero
+        @test_throws BoundsError eb[6]  #6 is not a valid index, the reward there is dummy, filled as zero
         ep2_len = 0
         for (j,i) = enumerate(8:11)
             ep2_len += 1

test/traces.jl

@@ -167,8 +167,10 @@ end
     @test t1[:reward][1] == 5
 
     @test size(Base.getindex(t1, :reward)) == (1,)
-    @test size(Base.getindex(t1, 1).state) == (2,3)
 
+    push!(t1, Val(:state), ones(2,3))
+
+    @test t1[:state][1] == ones(2,3)
 
     t2 = Traces(; a=[2, 3], b=[false, true])
     push!(t2, Val(:a), 5)