Skip to content

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Nov 25, 2025

No description provided.

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

Removed citation section from the documentation.
@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

Replaced LaTeX equation with plain text representation.
@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@tmigot
Copy link
Member Author

tmigot commented Nov 25, 2025

You can check the preview here: https://jso.dev/JSOSolvers.jl/previews/PR333/ @giovannifereoli

@giovannifereoli
Copy link

You already explain this nicely in the paper - it’s just missing here in the docs. Adding a short sentence in the Statement of Need about why matrix-free optimization matters (e.g., large-scale problems, high-dimensional decision vectors, ML workflows where Hessians are impractical) would make the motivation clearer

Copilot AI review requested due to automatic review settings November 26, 2025 15:08
Copilot finished reviewing on behalf of tmigot November 26, 2025 15:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the documentation by adding more detailed information about JSOSolvers.jl, reorganizing content, and improving user guidance. The changes expand the introduction with mathematical formulation, motivation, and installation instructions, while moving tutorial references to a dedicated examples page.

  • Expands the main documentation with mathematical problem formulation, solver approach description, and installation instructions
  • Creates a new examples page for tutorials and learning resources
  • Adds a documentation badge reference in the README

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docs/src/index.md Adds mathematical formulation, solver description, installation section, and bug reporting guidelines; removes tutorials section
docs/src/examples.md New file containing tutorial references and example resources
docs/make.jl Registers the new examples.md page in the documentation structure
README.md Adds reference to documentation badge for easier access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

Added explanation of function properties and optimization methods.
@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@tmigot
Copy link
Member Author

tmigot commented Nov 27, 2025

You already explain this nicely in the paper - it’s just missing here in the docs. Adding a short sentence in the Statement of Need about why matrix-free optimization matters (e.g., large-scale problems, high-dimensional decision vectors, ML workflows where Hessians are impractical) would make the motivation clearer

Hi @giovannifereoli
I updated the PR accordingly and also taking into account #329 (comment) . Can you tell me if you have more comments ?

The preview is here: https://jso.dev/JSOSolvers.jl/previews/PR333/

@giovannifereoli
Copy link

The documentation looks great now!

Would you mind adding an extra link to the docs in the README or the repo description, so it’s easy to find even without clicking the badge?

@giovannifereoli
Copy link

Heads up, I’m added an item to the checklist above regarding automated testing!

stats = lbfgs(nlp) # or trunk, tron, R2
```

Click on the badge [![](https://img.shields.io/badge/docs-stable-3f51b5.svg)](https://jso.dev/JSOSolvers.jl/stable) to access the documentation.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giovannifereoli It was added here already, do you think of a better place ?
Preview: https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/blob/add-joss-comments-docs/README.md

@giovannifereoli
Copy link

Maybe something like this could work:

Documentation

Click on the badge

to access the documentation.

Just a personal preference!

@github-actions
Copy link
Contributor

Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants