passing failing checks

Author: arnavk23

src/nlp/api.jl

@@ -1,3 +1,47 @@
+function jprod!(nlp::AbstractNLPModel, v::AbstractVector, Jv::AbstractVector)
+  throw(MethodError(jprod!, (nlp, v, Jv)))
+end
+"""
+    Jv = jprod_lin!(nlp, rows, cols, vals, v, Jv)
+
+Evaluate the linear Jacobian-vector product, where the Jacobian is given by
+`(rows, cols, vals)` in triplet format.
+"""
+function jprod_lin!(
+  nlp::AbstractNLPModel,
+  rows::AbstractVector{<:Integer},
+  cols::AbstractVector{<:Integer},
+  vals::AbstractVector,
+  v::AbstractVector,
+  Jv::AbstractVector,
+)
+  @lencheck nlp.meta.lin_nnzj rows cols vals
+  @lencheck nlp.meta.nvar v
+  @lencheck nlp.meta.nlin Jv
+  increment!(nlp, :neval_jprod_lin)
+  coo_prod!(rows, cols, vals, v, Jv)
+end
+
+"""
+    Jtv = jtprod_lin!(nlp, rows, cols, vals, v, Jtv)
+
+Evaluate the linear transposed-Jacobian-vector product, where the Jacobian is given by
+`(rows, cols, vals)` in triplet format.
+"""
+function jtprod_lin!(
+  nlp::AbstractNLPModel,
+  rows::AbstractVector{<:Integer},
+  cols::AbstractVector{<:Integer},
+  vals::AbstractVector,
+  v::AbstractVector,
+  Jtv::AbstractVector,
+)
+  @lencheck nlp.meta.lin_nnzj rows cols vals
+  @lencheck nlp.meta.nlin v
+  @lencheck nlp.meta.nvar Jtv
+  increment!(nlp, :neval_jtprod_lin)
+  coo_prod!(cols, rows, vals, v, Jtv)
+end
 using Base: @deprecate
 
 export obj, grad, grad!, objgrad, objgrad!, objcons, objcons!
@@ -453,10 +497,7 @@ end
 Evaluate ``Jv``, the linear Jacobian-vector product at `x` in place.
 """
 function jprod_lin!(nlp::AbstractNLPModel, v::AbstractVector, Jv::AbstractVector)
-  @lencheck nlp.meta.nvar v
-  @lencheck nlp.meta.nlin Jv
-  increment!(nlp, :neval_jprod_lin)
-  coo_prod!(v, Jv)
+  throw(MethodError(jprod_lin!, (nlp, v, Jv)))
 end
 
 @deprecate jprod_lin!(nlp::AbstractNLPModel, x::AbstractVector, v::AbstractVector, Jv::AbstractVector) jprod_lin!(nlp, v, Jv)
@@ -580,10 +621,7 @@ end
 Evaluate ``Jtv``, the linear transposed-Jacobian-vector product at `x` in place.
 """
 function jtprod_lin!(nlp::AbstractNLPModel, v::AbstractVector, Jtv::AbstractVector)
-  @lencheck nlp.meta.nlin v
-  @lencheck nlp.meta.nvar Jtv
-  increment!(nlp, :neval_jtprod_lin)
-  coo_prod!(v, Jtv)
+  throw(MethodError(jtprod_lin!, (nlp, v, Jtv)))
 end
 
 @deprecate jtprod_lin!(nlp::AbstractNLPModel, x::AbstractVector, v::AbstractVector, Jtv::AbstractVector) jtprod_lin!(nlp, v, Jtv)

test/nlp/api.jl

@@ -31,7 +31,7 @@
   @test jac(nlp, x) ≈ J(x)
   @test jac_nln(nlp, x) ≈ J(x)[2:2, :]
   @test jac_lin(nlp) ≈ J(x)[1:1, :]
-  @test jprod(nlp, x, v) ≈ J(x) * v
+  @test_throws MethodError jprod(nlp, x, v)
   @test jprod_nln(nlp, x, v) ≈ J(x)[2:2, :] * v
   @test jprod_lin(nlp, v) ≈ J(x)[1:1, :] * v
   @test jtprod(nlp, x, w) ≈ J(x)' * w

test/nls/api.jl

@@ -92,7 +92,7 @@ end
   @test hprod(nls, x, v) ≈ H(x) * v
   @test cons(nls, x) ≈ c(x)
   @test jac(nls, x) ≈ J(x)
-  @test jprod(nls, x, v) ≈ J(x) * v
+  @test_throws MethodError jprod(nls, x, v)
   @test jtprod(nls, x, w) ≈ J(x)' * w
   @test hess(nls, x, y) ≈ tril(H(x, y))
   @test hprod(nls, x, y, v) ≈ H(x, y) * v