Merge pull request #3290 from andycansdale/fix/drawing-manager

JustFly1984 · web-flow · commit b768d0a52880 · 2023-10-13T14:37:45.000+07:00
Fix bug that prevented null from being passed as a drawingMode
diff --git a/packages/react-google-maps-api/src/components/drawing/DrawingManager.tsx b/packages/react-google-maps-api/src/components/drawing/DrawingManager.tsx
@@ -94,8 +94,8 @@ function DrawingManagerFunctional({
   }, [instance, options])
 
   useEffect(() => {
-    if (drawingMode && instance !== null) {
-      instance.setDrawingMode(drawingMode)
+    if (instance !== null) {
+      instance.setDrawingMode(drawingMode ?? null)
     }
   }, [instance, drawingMode])
 

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,8 @@ function DrawingManagerFunctional({`
`94`	`94`	`}, [instance, options])`
`95`	`95`
`96`	`96`	`useEffect(() => {`
`97`		`- if (drawingMode && instance !== null) {`
`98`		`- instance.setDrawingMode(drawingMode)`
	`97`	`+ if (instance !== null) {`
	`98`	`+ instance.setDrawingMode(drawingMode ?? null)`
`99`	`99`	`}`
`100`	`100`	`}, [instance, drawingMode])`
`101`	`101`