Skip to content

Commit ce85f08

Browse files
committed
fix warnings caused by connect(nullptr, ...)
1 parent 3924155 commit ce85f08

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/resultsbottomuppage.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ ResultsBottomUpPage::ResultsBottomUpPage(FilterAndZoomStack* filterStack, PerfPa
6868
ResultsUtil::setupCostDelegate(m_model, ui->bottomUpTreeView);
6969
ResultsUtil::setupContextMenu(ui->bottomUpTreeView, contextMenu, m_model, filterStack, this);
7070

71-
connect(parser, &PerfParser::bottomUpDataAvailable, this, &ResultsBottomUpPage::setBottomUpResults);
71+
if (parser)
72+
connect(parser, &PerfParser::bottomUpDataAvailable, this, &ResultsBottomUpPage::setBottomUpResults);
7273

7374
ResultsUtil::setupResultsAggregation(ui->costAggregationComboBox);
7475
}

src/resultspagediff.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ ResultsPageDiff::ResultsPageDiff(QWidget* parent)
4444
, m_exportMenu(new QMenu(tr("Export"), this))
4545
, m_resultsBottomUpPage(
4646
new ResultsBottomUpPage(m_filterAndZoomStack, nullptr, m_costContextMenu, m_exportMenu, this))
47-
, m_resultsTopDownPage(new ResultsTopDownPage(m_filterAndZoomStack, m_fileA, m_costContextMenu, this))
48-
, m_resultsFlameGraphPage(new ResultsFlameGraphPage(m_filterAndZoomStack, m_fileA, m_exportMenu, this))
49-
, m_resultsCallerCalleePage(new ResultsCallerCalleePage(m_filterAndZoomStack, m_fileA, m_costContextMenu, this))
50-
, m_timeLineWidget(new TimeLineWidget(m_fileA, m_filterMenu, m_filterAndZoomStack, this))
47+
, m_resultsTopDownPage(new ResultsTopDownPage(m_filterAndZoomStack, nullptr, m_costContextMenu, this))
5148
{
5249
m_exportMenu->setIcon(QIcon::fromTheme(QStringLiteral("document-export")));
5350
{

src/resultstopdownpage.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ ResultsTopDownPage::ResultsTopDownPage(FilterAndZoomStack* filterStack, PerfPars
2828
ResultsUtil::setupCostDelegate(m_model, ui->topDownTreeView);
2929
ResultsUtil::setupContextMenu(ui->topDownTreeView, contextMenu, m_model, filterStack, this);
3030

31-
connect(parser, &PerfParser::topDownDataAvailable, this, &ResultsTopDownPage::setTopDownResults);
31+
if (parser)
32+
connect(parser, &PerfParser::topDownDataAvailable, this, &ResultsTopDownPage::setTopDownResults);
3233

3334
ResultsUtil::setupResultsAggregation(ui->costAggregationComboBox);
3435
}

0 commit comments

Comments
 (0)