Merge topic 'volume_rendering_opengl2_fixes'

c7f6106 Removed unused file
da53064 Another pass on disabling HAVS mapper
dd24a4f OpenGL2 backend does not support HAVSMapper

Author: utkarshayachit

ParaViewCore/ServerImplementation/Rendering/CMakeLists.txt

@@ -40,6 +40,11 @@ set (Module_SRCS
   vtkSICompositeOrthographicSliceRepresentationProxy.cxx
 )
 
+# OpenGL2 specific definitions
+if("${VTK_RENDERING_BACKEND}" STREQUAL "OpenGL2")
+  add_definitions(-DVTKGL2)
+endif()
+
 #------------------------------------------------------------------------------
 vtk_module_library(vtkPVServerImplementationRendering
   ${Module_SRCS})

ParaViewCore/ServerImplementation/Rendering/vtkSIUnstructuredGridVolumeRepresentationProxy.cxx

@@ -43,12 +43,14 @@ void vtkSIUnstructuredGridVolumeRepresentationProxy::OnCreateVTKObjects()
          << "Projected tetra"
          << this->GetSubSIProxy("VolumePTMapper")->GetVTKObject()
          << vtkClientServerStream::End;
+#ifndef VTKGL2
   stream << vtkClientServerStream::Invoke
          << self
          << "AddVolumeMapper"
          << "HAVS"
          << this->GetSubSIProxy("VolumeHAVSMapper")->GetVTKObject()
          << vtkClientServerStream::End;
+#endif
   stream << vtkClientServerStream::Invoke
          << self
          << "AddVolumeMapper"
@@ -70,6 +72,7 @@ void vtkSIUnstructuredGridVolumeRepresentationProxy::OnCreateVTKObjects()
 void vtkSIUnstructuredGridVolumeRepresentationProxy::UpdateRenderViewExtensions(
   vtkSIViewProxy* view)
 {
+#ifndef VTKGL2
   vtkSIRenderViewProxy* rvp = vtkSIRenderViewProxy::SafeDownCast(view);
   if (!rvp)
     {
@@ -108,6 +111,7 @@ void vtkSIUnstructuredGridVolumeRepresentationProxy::UpdateRenderViewExtensions(
       this->SupportsHAVSMapper = 1;
       }
     }
+#endif
   this->RenderViewExtensionsTested = 1;
 }
 #endif

ParaViewCore/ServerManager/SMApplication/CMakeLists.txt

@@ -37,6 +37,11 @@ SET_SOURCE_FILES_PROPERTIES(
   ABSTRACT
   )
 
+# OpenGL2 specific definitions
+if("${VTK_RENDERING_BACKEND}" STREQUAL "OpenGL2")
+  add_definitions(-DVTKGL2)
+endif()
+
 vtk_module_library(vtkPVServerManagerApplication ${Module_SRCS})
 
 #------------------------------------------------------------------------------

ParaViewCore/ServerManager/SMApplication/Resources/rendering.xml

@@ -134,9 +134,11 @@
     <Proxy class="vtkProjectedTetrahedraMapper"
            name="ProjectedTetrahedraMapper"
            processes="client|renderserver|dataserver"></Proxy>
+#ifndef VTKGL2
     <Proxy class="vtkHAVSVolumeMapper"
            name="HAVSVolumeMapper"
            processes="client|renderserver|dataserver"></Proxy>
+#endif
     <Proxy name="DummyVolumeMapper">
       <ProxyProperty command="SetRayCastFunction"
                      name="RayCastFunction">

ParaViewCore/ServerManager/SMApplication/Resources/views_and_representations.xml

@@ -3885,7 +3885,9 @@
         rendering.</Documentation>
         <StringListDomain name="list">
           <String value="Projected tetra" />
+#ifndef VTKGL2
           <String value="HAVS" />
+#endif
           <String value="Z sweep" />
           <String value="Bunyk ray cast" />
         </StringListDomain>
@@ -3928,12 +3930,14 @@
                proxyname="ProjectedTetrahedraMapper"></Proxy>
         <ShareProperties subproxy="VolumeDummyMapper"></ShareProperties>
       </SubProxy>
+#ifndef VTKGL2
       <SubProxy>
         <Proxy name="VolumeHAVSMapper"
                proxygroup="mappers"
                proxyname="HAVSVolumeMapper"></Proxy>
         <ShareProperties subproxy="VolumeDummyMapper"></ShareProperties>
       </SubProxy>
+#endif
       <!-- end of UnstructuredGridVolumeRepresentation -->
     </RepresentationProxy>