Merge branch 'master' into develop

Author: fzhinkin

README.md

@@ -4,6 +4,20 @@
 [![License](https://img.shields.io/github/license/Kotlin/binary-compatibility-validator)](LICENSE.TXT)
 [![KDoc link](https://img.shields.io/badge/API_reference-KDoc-blue)](https://kotlin.github.io/binary-compatibility-validator/)
 
+# Support for this plugin has been discontinued
+
+> [!WARNING]
+> The development of a separate binary compatibility validator Gradle plugin has been discontinued, 
+> and all its functionality will be moved to Kotlin Gradle Plugin starting from the [`2.2.0` release](https://kotlinlang.org/docs/whatsnew22.html#binary-compatibility-validation-included-in-kotlin-gradle-plugin).
+> 
+> As part of the migration, the code of the current plugin has been migrated to [the Kotlin repository](https://github.com/JetBrains/kotlin/tree/master/libraries/tools/abi-validation), 
+> as well as issues migrated to [the Kotlin project in YouTrack](https://youtrack.jetbrains.com/issues/KT?q=subsystems:%20%7BTools.%20BCV%7D,%20%7BTools.%20Gradle.%20BCV%7D).
+> 
+> This plugin is frozen from changes, no new features or minor bugfixes will be added to it.
+> 
+> The functionality of working with the ABI in Kotlin Gradle Plugin is in an experimental state now, 
+> so it is recommended to continue using this plugin in production projects until KGP API stabilization.
+
 # Binary compatibility validator
 
 The tool allows dumping binary API of a JVM part of a Kotlin library that is public in the sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.

src/main/kotlin/api/AsmMetadataLoading.kt

@@ -39,7 +39,7 @@ internal fun ClassNode.isEffectivelyPublic(classVisibility: ClassVisibility?) =
 
 
 private val ClassNode.innerClassNode: InnerClassNode? get() = innerClasses.singleOrNull { it.name == name }
-private fun ClassNode.isLocal() = outerMethod != null
+private fun ClassNode.isLocal() = outerClass != null // using outerMethod is unreliable, because even for local classes outerMethod can sometimes be null
 private fun ClassNode.isInner() = innerClassNode != null
 private fun ClassNode.isWhenMappings() = isSynthetic(access) && name.endsWith("\$WhenMappings")
 private fun ClassNode.isSyntheticAnnotationClass() = isSynthetic(access) && name.contains("\$annotationImpl\$")

src/test/kotlin/tests/PrecompiledCasesTest.kt

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2016-2025 JetBrains s.r.o.
+ * Use of this source code is governed by the Apache 2.0 License that can be found in the LICENSE.txt file.
+ */
+
+package kotlinx.validation.api.tests
+
+import kotlinx.validation.api.*
+import org.junit.*
+import org.junit.rules.TestName
+import java.io.File
+import java.nio.file.Path
+import kotlin.io.path.ExperimentalPathApi
+import kotlin.io.path.walk
+
+class PrecompiledCasesTest {
+
+    companion object {
+        val baseOutputPath = File("src/test/resources/precompiled")
+    }
+
+    @Rule
+    @JvmField
+    val testName = TestName()
+
+    @Test fun parcelable() { snapshotAPIAndCompare(testName.methodName) }
+
+    @OptIn(ExperimentalPathApi::class)
+    private fun snapshotAPIAndCompare(testClassRelativePath: String, nonPublicMarkers: Set<String> = emptySet()) {
+        val testClasses = baseOutputPath.toPath().walk().map(Path::toFile).toList()
+        check(testClasses.isNotEmpty()) { "No class files are found in path: $baseOutputPath" }
+
+        val testClassStreams = testClasses.asSequence().filter { it.name.endsWith(".class") }.map { it.inputStream() }
+        val classes = testClassStreams.loadApiFromJvmClasses()
+        val additionalPackages = classes.extractAnnotatedPackages(nonPublicMarkers)
+        val api = classes.filterOutNonPublic(nonPublicPackages = additionalPackages).filterOutAnnotated(nonPublicMarkers)
+        val target = baseOutputPath.resolve(testClassRelativePath).resolve(testName.methodName + ".txt")
+        api.dumpAndCompareWith(target)
+    }
+}